Commit Graph

1807 Commits

Author SHA1 Message Date
Bond_009
2ed0801be2 Fix possible nullref
when `ProviderManager.SaveMetadata` gets called before
`ProviderManager.AddParts`

```
Error Message:
   System.ArgumentNullException : Value cannot be null. (Parameter 'source')
  Stack Trace:
     at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType, IEnumerable`1 savers) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 674
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 655
   at Emby.Server.Implementations.Library.LibraryManager.RunMetadataSavers(BaseItem item, ItemUpdateType updateReason) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 2012
   at Emby.Server.Implementations.Library.LibraryManager.UpdateItemsAsync(IReadOnlyList`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 1970
   at Emby.Server.Implementations.Library.LibraryManager.CreateRootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 775
   at Emby.Server.Implementations.Library.LibraryManager.get_RootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 180
   at Emby.Server.Implementations.IO.LibraryMonitor.Start() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitor.cs:line 135
   at Emby.Server.Implementations.IO.LibraryMonitorStartup.RunAsync() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitorStartup.cs:line 26
   at Emby.Server.Implementations.ApplicationHost.StartEntryPoints(IEnumerable`1 entryPoints, Boolean isBeforeStartup)+MoveNext() in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 541
   at System.Threading.Tasks.Task.WhenAll(IEnumerable`1 tasks)
   at Emby.Server.Implementations.ApplicationHost.RunStartupTasksAsync(CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 525
   at Jellyfin.Server.Integration.Tests.JellyfinApplicationFactory.CreateServer(IWebHostBuilder builder) in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\JellyfinApplicationFactory.cs:line 101
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.EnsureServer()
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(Uri baseAddress, DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient()
   at Jellyfin.Server.Integration.Tests.OpenApiSpecTests.GetSpec_ReturnsCorrectResponse() in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\OpenApiSpecTests.cs:line 26
--- End of stack trace from previous location ---
```
2021-04-04 01:45:15 +02:00
Bond-009
7c51d0a50e
Merge pull request #5671 from jellyfin/tmdbmovieprovider-originaltitle
set original title in tmdbmovieprovider
2021-04-01 17:39:22 +02:00
Claus Vium
df60d176b8
ensure only valid images are saved in ItemImageProvider 2021-04-01 15:27:28 +02:00
Claus Vium
28a0eb6d53
set original title in tmdbmovieprovider 2021-04-01 14:28:03 +02:00
Bond-009
16011d96a0
Merge pull request #5321 from Ullmie02/nfo-thumb 2021-03-25 01:10:37 +01:00
David
a4cac09d5b Use |= 2021-03-23 19:25:32 +01:00
Erwin de Haan
470305f75e Authenticated arbitrary file overwrite in SubtitleController -> SubtitleManager
GHSL-2021-050: Issue 5 Arbitrary file overwrite.
2021-03-20 01:14:59 +01:00
cvium
151156f227 Clean the entity name for non-words before searching 2021-03-17 10:29:45 +01:00
Bond_009
a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
Claus Vium
84e16a8535
Merge pull request #5431 from cvium/fix_tmdb_imdbid
Use imdbid as fallback in movie provider
2021-03-10 08:37:00 +01:00
Bond-009
97fd136a8c
Merge pull request #5428 from cvium/fix_tmdb_year
Default to the searchinfo year, fallback to parsed year
2021-03-09 15:59:37 +01:00
cvium
880c8636bc Use imdbid as fallback in movie provider
Includes post-ProviderIdExtensions cleanup
2021-03-09 11:44:39 +01:00
cvium
80fb52e64f Default to the searchinfo year, fallback to parsed year 2021-03-09 10:46:54 +01:00
Bond_009
d202df6e8a Remove useless line 2021-03-09 03:22:51 +01:00
Bond_009
9ed7f429c0 FxCop -> Net Analyzers (part 1) 2021-03-09 03:04:47 +01:00
David
60ffa6f514 Use FileShare.None when creating files 2021-03-07 14:43:28 +01:00
cvium
ba366118f9 Do not use language or imagelanguages when searching for images
TMDb API returns all images if languages are excluded, which is needed for the All Languages toggle in Identify.
2021-03-05 08:18:04 +01:00
cvium
664c5da317 return false when providerid is null or empty 2021-03-03 09:09:57 +01:00
David Ullmer
8f99bdd07c
Fix TMDb search name containing year (#5349) 2021-03-02 21:17:25 +01:00
David
16694b0cfc Add nfo thumb tag support 2021-02-28 15:00:17 +01:00
Joshua M. Boniface
5ce4df4178
Merge pull request #5270 from Bond-009/imdb 2021-02-22 20:59:57 -05:00
dkanada
175e2a5249
Merge pull request #5242 from jellyfin/cancellationtokens
Properly forward cancellationTokens
2021-02-20 10:52:30 +09:00
Bond_009
b2700ecf44 TMDB: Also search with IMDB or TVDB Id if specified 2021-02-19 16:09:23 +01:00
Bond_009
c1b17b2fa4 TMDB: Include year in search 2021-02-18 22:58:18 +01:00
Bond_009
e9f22303a4 Properly forward cancellationTokens 2021-02-15 14:19:17 +01:00
Mariusz Chryc
0d1f356373 Remove season name from metadata result 2021-01-26 19:04:20 +01:00
Bond_009
eeff9f52c6 Fix Omdb caching 2021-01-12 16:27:38 +01:00
crobibero
c1d1b6e9f4 Fix serialization loop 2021-01-04 07:52:44 -07:00
crobibero
a3a31952f4 Fix OMDb converter 2021-01-03 09:35:22 -07:00
Joshua M. Boniface
406ae3e43a
Merge pull request #4709 from BaronGreenback/PluginDowngrade 2020-12-31 18:47:05 -05:00
martinek-stepan
cc92f7afe5
Enable nullable for MediaBrowser.XbmcMetadata project (#4612)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Stepan <ste.martinek+git@gmail.com>
2020-12-31 12:09:25 +01:00
Cody Robibero
5c57569692
Merge branch 'master' into PluginDowngrade 2020-12-30 18:11:37 -07:00
Bond-009
054adf6379
Merge pull request #4853 from Ullmie02/servicestack-json 2020-12-30 10:33:32 +01:00
David
9e0f425783 Make RootObject and SeasonRootObject internal again 2020-12-28 23:41:46 +01:00
David
21fd124bca Code revie 2020-12-27 11:15:46 +01:00
David
f73bb92ce3 Remove manual N/A removal and write directly to stream 2020-12-26 20:00:54 +01:00
David
e0499f8769 Remove attributes 2020-12-25 19:37:38 +01:00
crobibero
fc212e5e5f Remove JsonOmdbNotAvailableConverterFactory 2020-12-25 14:43:10 +01:00
crobibero
6ddbe8420f Add tests for special Omdb json 2020-12-25 14:43:10 +01:00
David
043d045448 Put json serializer options in private field 2020-12-24 11:22:34 +01:00
crobibero
570b4dc0d0 Explicity reference Newtonsoft.Json 2020-12-23 12:34:07 -07:00
David
2a574914ea Use streams instead of strings 2020-12-23 19:24:58 +01:00
BaronGreenback
889e988167 Updated to latest unstable. 2020-12-23 17:25:34 +00:00
David
e2d338412f Fix OMDb "N/A" 2020-12-23 14:45:05 +01:00
David
276b219fbd Add missing options 2020-12-23 13:47:57 +01:00
David
e09d3ba9ef Remove custom Json serializer from Providers 2020-12-23 13:14:39 +01:00
crobibero
1dac2226c4 Remove unused deps 2020-12-22 08:57:51 -07:00
Greenback
ce19f2be55 Renamed Guid property to Id 2020-12-18 20:37:35 +00:00
cvium
9f6000d845 Add missing seasons during AfterMetadataRefresh 2020-12-15 08:18:36 +01:00
cvium
3f6e6c4839 Simplify 2020-12-10 14:47:47 +01:00