Commit Graph

201 Commits

Author SHA1 Message Date
Bond-009
ee637e8fec Fix warnings, improve performance (#1665)
* Fix warnings, improve performance

`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)

* Update Providers .csproj to latest C#

* Remove extra newline from DtoService.cs

* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Bond-009
6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
Bond-009
a6f9ceedd8 Fix more warnings 2019-06-01 11:31:27 +02:00
Bond-009
bf43dc00bb More warning fixes 2019-03-13 22:32:52 +01:00
Bond_009
37ea50a572 Reduce the amount of exceptions thrown 2019-03-07 21:42:56 +01:00
Joshua M. Boniface
89d4ce309d
Merge pull request #848 from Bond-009/perf
Minor changes to reduce allocations
2019-02-19 21:24:51 -05:00
Bond_009
3e6819c718 Don't clone lists 2019-02-12 21:06:47 +01:00
Bond_009
41fb1e5106 Tuple -> ValueTuple 2019-02-12 21:06:47 +01:00
Bond_009
64d5ec12e2 Use HashSets for increased perf 2019-02-12 21:06:47 +01:00
Bond_009
a6a4cd5667 Removed some unused fields 2019-02-09 15:57:42 +01:00
Joshua M. Boniface
c713824bf9
Merge pull request #734 from Bond-009/culture
Fix more analyzer warnings
2019-01-31 21:11:13 -05:00
Claus Vium
8985fb8d58 Remove support for games as a media type 2019-01-31 19:04:47 +01:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture 2019-01-30 16:57:15 +01:00
Erwin de Haan
b9a111432a Unwrapped all /(Write|Read)All(Text|Bytes)/ functions. 2019-01-28 22:10:50 +01:00
Erwin de Haan
581a7fe078 Unwrapped MoveDirectory, DirectoryExists, FileExists & removed MoveFile 2019-01-28 22:10:00 +01:00
Erwin de Haan
d7c6d16250 Unwrapped CreateDirectory and DeleteDirectory 2019-01-28 22:09:56 +01:00
Erwin de Haan
3a831994f6 Unwrapped GetDirectoryName and DirectorySeperatorChar 2019-01-28 22:06:34 +01:00
Bond_009
ffe79c8982 Check if file exists instead of catching exceptions 2019-01-27 17:00:17 +01:00
Bond_009
a709cbdc64 Fix more analyzer warnings 2019-01-27 12:12:44 +01:00
William Taylor
65cd3ed597 Replaced injections of ILogger with ILoggerFactory
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.

The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.

Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Erwin de Haan
321c440739 Reformat JustAMan review pt1 changes
Refs #575
2019-01-17 20:24:01 +01:00
Erwin de Haan
e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan
65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan
58b582bdcb Visual Studio Reformat: Emby.Server.Implementations Part I-Lib 2019-01-13 20:21:32 +01:00
Erwin de Haan
e2751d42e8 Merge branch 'dev' into code-cleanup 2019-01-11 12:50:36 +01:00
Erwin de Haan
ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken
bd169e4fd4 remove trailing whitespace 2019-01-07 23:27:46 +00:00
Bond_009
ea4c914123 Fix exception logging 2018-12-30 22:44:39 +01:00
Bond_009
b7ebb67cbb Remove the need for NullLogger 2018-12-30 22:44:38 +01:00
Bond_009
0f8b3c6347 Use Microsoft.Extensions.Logging abstraction 2018-12-30 22:44:38 +01:00
Erwin de Haan
9c1c29325d Added extra extension method that create a new instance of the destination object. 2018-12-30 01:25:42 +01:00
Erwin de Haan
de7fcaadb3 Fixed #320 by adding an extension method to BaseItem to make a deep copy of an object. 2018-12-30 01:12:33 +01:00
Bond_009
6e5d2aadaa Remove custom ToArray extension 2018-12-28 16:48:26 +01:00
Bond_009
22093c9e8f Removed some warnings 2018-12-16 00:49:18 +01:00
stefan
48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti
58a7829ecd update library changed notifier 2017-11-25 23:48:12 -05:00
Luke Pulverenti
351d29954a 3.2.36.8 2017-11-12 16:05:40 -05:00
Luke Pulverenti
711f588084 3.2.36.7 2017-11-10 16:22:38 -05:00
Luke Pulverenti
d765f370b3 update librarymanager 2017-11-01 15:56:20 -04:00
Luke Pulverenti
0a0303ca64 normalize strm file contents 2017-11-01 15:50:16 -04:00
Luke Pulverenti
ca2e7a4195 deprecate localized guids config switch 2017-10-26 23:49:56 -04:00
Luke Pulverenti
7e5036a587 update image aspect ratio detection 2017-10-22 02:22:43 -04:00
Luke Pulverenti
a5b82cd2ec remove unneeded async signatures 2017-10-03 14:39:37 -04:00
Luke Pulverenti
de5a8d579b move season zero display name to per library settings 2017-09-24 16:23:56 -04:00
Luke Pulverenti
99f4dd95e9 handle files already being deleted 2017-09-21 17:36:32 -04:00
Luke Pulverenti
cdd79ec7e2 update owned items 2017-09-18 12:52:22 -04:00
Luke Pulverenti
b8834be83c update naming project to target .net standard 2017-09-10 16:40:31 -04:00
Luke Pulverenti
fe10df6935 improve queries from scheduled tasks 2017-09-09 23:18:23 -04:00
Luke Pulverenti
39c4542cf6 update query objects 2017-09-04 15:28:22 -04:00
Luke Pulverenti
e287e3a50d remove async when there's nothing to await 2017-08-26 20:32:33 -04:00
Luke Pulverenti
f4765a87cc update m3u tuner 2017-08-20 15:10:00 -04:00
Luke Pulverenti
1ad990ad72 update live tv data transfer 2017-08-19 15:43:35 -04:00
Luke Pulverenti
b7867214ef update download error handling 2017-08-11 17:55:48 -04:00
Luke Pulverenti
a7db7cd40c reduce traffic from session player 2017-08-11 02:29:49 -04:00
Luke Pulverenti
40442f887b consolidate emby.server.core into emby.server.implementations 2017-08-09 15:56:38 -04:00
Luke Pulverenti
52aeb3c40b consolidate interfaces 2017-08-07 17:06:13 -04:00
Luke Pulverenti
994720c24a deprecate hddvd videotype 2017-08-07 16:36:41 -04:00
Luke Pulverenti
2ed625d27e update themes 2017-07-31 01:16:22 -04:00
Luke Pulverenti
9a4fe6625d xml tv fixes 2017-06-27 16:55:22 -04:00
Luke Pulverenti
1e5c3db9eb support individual library refreshing 2017-06-23 12:04:45 -04:00
Luke Pulverenti
ccb5b14d77 update series resolver 2017-06-15 13:22:05 -04:00
Luke Pulverenti
e91f569c15 update live tv startup 2017-06-03 03:36:32 -04:00
Luke Pulverenti
d8ec7109ab add FindByPath error handling 2017-05-30 14:24:50 -04:00
Luke Pulverenti
33014f77aa update GetItems method 2017-05-26 02:48:54 -04:00
Luke Pulverenti
f07af448fa update main projects 2017-05-24 15:12:55 -04:00
Luke Pulverenti
2f93d4498b update query fields 2017-05-23 12:43:24 -04:00
Luke Pulverenti
54cf0da758 update query fields 2017-05-22 00:54:02 -04:00
Luke Pulverenti
da77b05817 update data queries 2017-05-21 03:25:49 -04:00
Luke Pulverenti
47fc7c6aee add GenreItems property 2017-05-18 17:05:47 -04:00
Luke Pulverenti
369df3ffda add smb fixes 2017-05-10 15:12:03 -04:00
Luke Pulverenti
696a6b34ea improve smb support 2017-05-04 14:14:45 -04:00
Luke Pulverenti
a9b041a7e6 rework refresh queue 2017-04-29 22:37:51 -04:00
Luke Pulverenti
7ea3719a2d 3.2.12.11 2017-04-20 16:17:52 -04:00
Luke Pulverenti
dd715fbcc7 use alameda 2017-04-13 14:57:24 -04:00
Luke Pulverenti
7987e64d38 add new file method overloads 2017-03-30 13:56:32 -04:00
Luke Pulverenti
04b6f23473 3.2.9.1 2017-03-29 02:26:48 -04:00
Luke Pulverenti
b38b7a7062 rework filestream 2017-03-13 00:08:23 -04:00
Luke Pulverenti
9fa6868af3 update legacy hd homerun support 2017-03-07 13:27:56 -05:00
Luke Pulverenti
ce3f2bdd20 reduce AnalyzeDurationMs for live tv 2017-03-05 10:38:36 -05:00
Luke Pulverenti
6091e00e18 clean related files when deleting items 2017-02-18 03:32:17 -05:00
Luke Pulverenti
36f8eb1149 add db startup error handling 2017-02-17 16:11:13 -05:00
Luke Pulverenti
8deb423883 restore config settings for now 2017-02-08 13:50:33 -05:00
Luke Pulverenti
ac3ec6d185 update image saver 2017-02-04 16:22:55 -05:00
Luke Pulverenti
ab026ab2de restore localized guids switch 2017-01-29 15:00:29 -05:00
Luke Pulverenti
8a252c8ad6 remove dead code 2017-01-26 23:15:05 -05:00
Luke Pulverenti
88d9b3d09d remove localized guids 2017-01-26 15:10:19 -05:00
Luke Pulverenti
db4290c74c add error handling 2017-01-26 13:41:12 -05:00
Luke Pulverenti
0b5d4ce3f8 fix live tv folders being created in a loop 2017-01-11 12:56:26 -05:00
Luke Pulverenti
3b7b06f70b support .tp video container 2017-01-09 01:25:09 -05:00
Luke Pulverenti
853dbfc558 separate player selection into it's own script 2016-12-29 02:14:59 -05:00
Luke Pulverenti
b23bdfe9f2 add content type error handling 2016-12-24 02:41:53 -05:00
Luke Pulverenti
3674a65fae stop guide refresh when needed 2016-12-15 01:41:10 -05:00
Luke Pulverenti
e1b880a5a0 update series queries 2016-12-13 02:36:30 -05:00
Luke Pulverenti
d84bb7160f update next up queries 2016-12-12 14:40:27 -05:00
Luke Pulverenti
c2da52914c add SeriesStudioInfo object 2016-12-08 00:58:38 -05:00
Luke Pulverenti
016d8301f5 update series queries 2016-12-06 03:24:29 -05:00
Luke Pulverenti
aef79a796d update xml parsing 2016-12-02 15:10:35 -05:00
Luke Pulverenti
f275d7f3d2 reduce library queries 2016-11-21 03:54:53 -05:00
Luke Pulverenti
406e6cb813 update portable projects 2016-11-11 14:55:12 -05:00
Luke Pulverenti
e8c70da2b6 fix ipv6 2016-11-08 14:50:39 -05:00
Luke Pulverenti
3eb4091808 move additional classes to new server lib 2016-11-03 02:37:52 -04:00