Egor Bakanov
46e9f5ad2e
Fix recursive children lookup of folders ( #8678 )
...
Fixes https://github.com/jellyfin/jellyfin/issues/6193
Fixes https://github.com/jellyfin/jellyfin/issues/7226
2023-01-07 11:48:14 -07:00
Bond_009
52194f56b5
Replace != null with is not null
2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e
Replace == null with is null
2022-12-05 15:00:20 +01:00
Bond_009
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Luke F
e579b4d42d
Backport pull request #8189 from jellyfin/release-10.8.z
...
Fix GetItems IndexOutOfRangeException when IDs do not exist
Original-merge: 527ed0607d5f31a232293b39daac19018518b1a0
Merged-by: Claus Vium <cvium@users.noreply.github.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-09-23 23:09:34 -04:00
Niels van Velzen
61afd029df
Check for empty guid
2022-08-14 12:58:38 +02:00
Niels van Velzen
0f91244239
Use Guid for adjacentTo API parameter
2022-08-14 12:47:25 +02:00
Bond_009
7fdc0e3c3d
BaseItem: remove unused function
2022-03-11 16:21:32 +01:00
Claus Vium
53209830e7
Merge pull request #7346 from Bond-009/guid
...
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Joe Rogers
354f22d065
Add post filtering for theme song and video
2022-02-27 23:38:00 +01:00
Bond_009
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Claus Vium
488ce51032
Remove some allocations ( #7246 )
2022-01-28 12:21:40 +01:00
Bond_009
2dcb2f8a9f
Ban the usage of Task.Result
...
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
2022-01-22 16:48:31 +01:00
Cody Robibero
a60cb280a3
Properly populate QueryResult
2022-01-20 08:53:06 -07:00
Cody Robibero
32629cd7da
Use BaseItemKind where possible
2021-12-12 06:11:27 -07:00
Bond_009
1d19a5be61
Fix some warnings
...
down to 580
2021-11-09 22:29:33 +01:00
Bond_009
5726535a26
Fix some warnings
...
609 left
2021-11-09 13:14:31 +01:00
Cody Robibero
64652b6392
Fix and disable new dotnet6 warnings
2021-11-08 12:40:52 -07:00
Bond_009
0d16c48998
Fix some warnings
2021-09-09 15:59:13 +02:00
Cody Robibero
cba07b1ca6
Remove more and more warnings
2021-08-28 16:32:50 -06:00
Rich Lander
e3df4dcaae
Fix warnings in MediaBrowser.Controller
2021-08-13 20:34:36 -07:00
Rich Lander
ad6f27143f
Update MediaBrowser.Controller/Entities/Folder.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-08-11 13:38:23 -07:00
Rich Lander
0ce7a15534
Fix more warnings
2021-07-23 16:36:27 -07:00
Rich Lander
a7cc77e7fa
Fix partial set of MediaBrowser.Controller/Entities warnings
2021-07-23 13:49:18 -07:00
Cody Robibero
65f8d8c0cd
[CA1801] Parameter is never used. Remove the parameter or use it in the method body.
2021-07-10 10:09:02 -06:00
Claus Vium
f17d43c564
Merge pull request #6071 from BaronGreenback/DLNAFolderFixPart1
...
Make DLNA folders to work as expected.
2021-06-07 09:55:58 +02:00
Cody Robibero
d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) ( #6078 )
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-06-06 17:16:41 +02:00
BaronGreenback
48bb338352
Enable child items to be returned if a musicAlbum
2021-05-17 23:34:50 +01:00
crobibero
6bcbc2b88a
Reduce warnings in MediaBrowser.Controller
2021-05-13 07:33:11 -06:00
Bond_009
fb090df0b5
Enable nullable reference types for MediaBrowser.Controller
2021-05-07 00:39:20 +02:00
cvium
608cba817c
Reduce some allocations with the magic of spans etc.
2021-04-30 15:09:36 +02:00
Bond-009
48ed4b016c
Merge pull request #5808 from cvium/semi-fix-collection-perf
2021-04-21 13:52:51 +02:00
BaronGreenback
bc1cc2d04a
Remove unused using directives
2021-04-17 11:37:55 +01:00
cvium
d44b2e2ee5
fixes
2021-04-13 20:12:50 +02:00
cvium
723b6abcb3
Optimize the way items are grouped into collections
2021-04-13 15:38:13 +02:00
crobibero
ee23d06154
Use a more descriptive function name
2020-12-13 08:15:26 -07:00
crobibero
f5cce9e630
Use typed UserManager GetPreference
2020-12-11 15:04:14 -07:00
cvium
15a3d8d626
Forgot to revert some other changes, dunno if needed
2020-12-10 18:02:12 +01:00
Claus Vium
f1cc01f324
Merge pull request #4242 from Spacetech/library_scan_speed
...
Increase library scan and metadata refresh speed
2020-12-04 13:17:26 +01:00
Gary Wilber
f4edca7c27
Move MetadataRefreshThrottler to BaseItemManager
2020-12-02 18:51:53 -08:00
BaronGreenback
e8cb9cea7d
Merge branch 'master' into library_scan_speed
2020-11-21 22:54:40 +00:00
Joshua M. Boniface
bf54b5579c
Merge branch 'master' into defer_image_fetching
2020-11-21 17:20:31 -05:00
Joshua M. Boniface
7457c4a95d
Merge pull request #4499 from crobibero/more-param
...
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids
2020-11-20 12:34:18 -05:00
Gary Wilber
4a22380565
Merge remote-tracking branch 'upstream/master' into library_scan_speed
2020-11-19 18:44:16 -08:00
Greenback
9a323f6df0
More spelling corrections.
2020-11-18 13:46:14 +00:00
crobibero
3cc0dd7e12
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage.
2020-11-16 20:29:46 -07:00
Gary Wilber
e6d8c02944
Merge remote-tracking branch 'upstream/master' into library_scan_speed
2020-11-08 11:51:40 -08:00
Anthony Lavado
6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
...
Minor improvements
2020-11-02 11:10:39 -05:00
Bond_009
49569ca0a0
Use nameof where possible
2020-10-17 16:19:57 +02:00
Jan-Pieter Baert
ec91d3893d
Fix SA 1116 warnings
2020-10-12 20:05:11 +02:00