Bond_009
c7d50d640e
Replace == null with is null
2022-12-05 15:00:20 +01:00
Bond_009
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
luz paz
9ec2870b10
Fix various typos
...
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Cody Robibero
b8722d02a3
Merge pull request #7781 from crobibero/live-tv-infinite
...
(cherry picked from commit 77c73e241fe1705528e3ffbb42f074c46240b9fb)
Signed-off-by: crobibero <cody@robibe.ro>
2022-06-06 09:16:11 -04:00
Cody Robibero
ea69213e5b
Merge pull request #7785 from dmitrylyzo/clear-transcodinginfo
...
Clear TranscodingInfo if play method changed
(cherry picked from commit c9491cf317f83012dafe17e2a40a9548993c51f0)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-26 13:36:46 -04:00
Cody Robibero
900b630f5b
Merge pull request #7605 from crobibero/playback-start-stop
...
Add missing properties to PlaybackStart, PlaybackStop
(cherry picked from commit 9beb3aff4e0859aaf916e44388cbd6cbede8087f)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:51 -04:00
Claus Vium
53209830e7
Merge pull request #7346 from Bond-009/guid
...
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Bond_009
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Cody Robibero
ee46754238
Fix build and clean up
2022-01-14 08:14:31 -07:00
Fernando Fernández
5df6058a8e
Add FullNowPlayingQueue property
2022-01-14 14:40:27 +00:00
Bond_009
cbfa355e31
Update StyleCop
2021-12-24 18:28:27 +01:00
Cody Robibero
32629cd7da
Use BaseItemKind where possible
2021-12-12 06:11:27 -07:00
Patrick Barron
7180983654
Fix warnings in SessionManager
2021-10-03 21:41:22 -04:00
dkanada
f6c0db4bb5
merge branch 'master' into syncplay-sessions-fix
2021-09-06 13:42:48 +09:00
Bond_009
637e86478f
Fix some warnings
2021-09-03 19:32:11 +02:00
Patrick Barron
06d682c296
Merge remote-tracking branch 'origin/authenticationdb-efcore' into authenticationdb-efcore
2021-06-27 16:46:09 -04:00
Patrick Barron
bbac9ff67e
GetDeviceOptions always returns an instance of DeviceOptions
2021-06-27 16:42:26 -04:00
Patrick Barron
befedaf6fc
Update Emby.Server.Implementations/Session/SessionManager.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-06-25 21:13:38 -04:00
crobibero
397868be95
Fix issues with QuickConnect and AuthenticationDb
2021-06-23 21:07:08 -06:00
Patrick Barron
ae878fa051
Merge branch 'master' into authenticationdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/QuickConnect/QuickConnectManager.cs
# Emby.Server.Implementations/Session/SessionManager.cs
# Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
2021-06-23 20:22:12 -04:00
Bond_009
6f8ccab788
Move non-jellyfin extensions to separate project
2021-06-19 18:04:46 +02:00
Patrick Barron
be88efce3c
Merge branch 'master' into authenticationdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Devices/DeviceManager.cs
# Emby.Server.Implementations/HttpServer/Security/SessionContext.cs
# Emby.Server.Implementations/Security/AuthenticationRepository.cs
# Emby.Server.Implementations/Session/SessionManager.cs
# Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
# MediaBrowser.Controller/Library/IUserManager.cs
# MediaBrowser.Controller/Net/ISessionContext.cs
2021-06-18 18:56:10 -04:00
Patrick Barron
373155a063
Correctly handle devices without custom names
2021-06-18 16:57:46 -04:00
Claus Vium
1594385497
Merge pull request #6038 from crobibero/delete-existing-sessions
...
Don't logout if deviceId is null
2021-05-24 08:43:44 +02:00
Patrick Barron
a0c6f72762
Migrate authentication db to EF Core
2021-05-20 23:56:59 -04:00
Bond_009
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
2021-05-20 22:48:53 +02:00
Patrick Barron
a225f34796
Merge branch 'master' into authenticationdb-efcore
...
# Conflicts:
# Jellyfin.Api/Helpers/RequestHelpers.cs
2021-05-18 18:09:46 -04:00
crobibero
f53aa55bdb
Don't logout if deviceId is null.
2021-05-12 13:32:54 -06:00
BaronGreenback
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:51:14 +02:00
crobibero
940c30081e
Mark PasswordSha1 as obsolete
2021-04-22 06:49:54 -06:00
Patrick Barron
75df6965a0
Don't use database for QuickConnect
2021-04-13 20:01:21 -04:00
Patrick Barron
3ebc047434
Convert UpdateUser to solely async
2021-04-10 16:59:41 -04:00
Patrick Barron
8607b52541
Make device/session code async
2021-04-10 16:57:25 -04:00
Patrick Barron
44e71774b1
Rewrite device manager using EF Core
2021-04-10 16:17:36 -04:00
Patrick Barron
16ca8c7536
Remove unused SessionManager methods
2021-04-01 10:49:09 -04:00
Ionut Andrei Oanca
9eb740ba57
Fix storing outdated sessions in SyncPlay
2021-03-28 13:25:40 +02:00
dkanada
158e69c6f0
Merge pull request #4935 from ConfusedPolarBear/quickconnect-cleanup
...
Remove used quick connect tokens
2021-02-08 22:54:53 +09:00
Bill Thornton
cfca27e99a
Fix capitalization of Playstate message
2021-01-05 10:06:55 -05:00
Matt Montgomery
8dd83327b5
Remove quick connect tokens after usage
2021-01-02 16:37:43 -06:00
Ionut Andrei Oanca
0825ce687d
Add SessionControllerConnected event
2020-12-07 01:04:48 +01:00
Joshua M. Boniface
c98c2ab955
Merge branch 'master' into syncplay-enhanced
2020-11-27 09:46:18 -05:00
Patrick Barron
5790db05ba
Clean up DeviceManager and don't store capabilities on disk
2020-11-19 09:38:54 -05:00
Ionut Andrei Oanca
8819a9d478
Add playlist-sync and group-wait to SyncPlay
2020-10-16 12:06:29 +02:00
cvium
3d69bcd190
Fix playbackstart not triggering in the new eventmanager
2020-10-06 08:14:56 +02:00
Bond-009
e011659186
Merge pull request #4210 from nielsvanvelzen/typed-websocket-message
...
Use enum for WebSocket message types
2020-10-05 10:40:52 +02:00
Joshua M. Boniface
67e89dd525
Use nicer count comparitor
2020-10-04 17:00:13 -04:00
Joshua M. Boniface
df177b4752
Revert "Implement better count method"
...
This reverts commit 5aa519fd39
.
2020-10-04 15:52:39 -04:00
Joshua M. Boniface
5aa519fd39
Implement better count method
2020-10-04 15:46:57 -04:00
Joshua M. Boniface
8dfa2015d0
Make the count an int for cleanliness
2020-10-04 14:14:42 -04:00
Joshua M. Boniface
d0ec6872f3
Increase count check to 1
...
There's another way to disable a user anyways.
2020-10-04 14:06:20 -04:00