Commit Graph

79 Commits

Author SHA1 Message Date
Bond_009
c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
jgriff6
08e71010ae Clean up some ToList usage 2022-10-25 02:27:13 +01:00
ignacio laborde
5cd37686ac address PR comments 2022-10-25 00:38:58 +01:00
ignacio laborde
c6bf6e00de Remove unnecessary ToList usage 2022-10-25 00:38:57 +01:00
Bond_009
f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Cody Robibero
7bfc6b5679 Remove more warnings 2021-12-27 07:38:06 -07:00
Bond_009
637e86478f Fix some warnings 2021-09-03 19:32:11 +02:00
Bond_009
645825db36 Enable nullable for more files 2021-08-28 17:32:09 +02:00
Bond_009
19824bff94 Minor improvements 2021-08-15 23:48:19 +02:00
Bond_009
a13a569ca4 EnsureLibraryFolder: Minor optimization 2021-07-26 23:25:21 +02:00
Cody Robibero
65f8d8c0cd [CA1801] Parameter is never used. Remove the parameter or use it in the method body. 2021-07-10 10:09:02 -06:00
Bond_009
7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
Cody Robibero
e3f55a0c54
Reduce warnings in MediaBrowser.Controller (#6006)
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-11 13:55:46 +02:00
Bond-009
48ed4b016c
Merge pull request #5808 from cvium/semi-fix-collection-perf 2021-04-21 13:52:51 +02:00
BaronGreenback
bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
cvium
d44b2e2ee5 fixes 2021-04-13 20:12:50 +02:00
cvium
723b6abcb3 Optimize the way items are grouped into collections 2021-04-13 15:38:13 +02:00
Mister Rajoy
8883aa4a37 Merge branch 'master' of https://github.com/danieladov/jellyfin 2021-03-13 20:35:52 +01:00
Mister Rajoy
4cc3b938fa Change Guid.Parse to Guid.TryParse 2021-03-13 20:33:05 +01:00
Daniel
7a3109104b
Remove empty line
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-03-13 19:24:02 +01:00
Daniel
4b17648df3
Remove empty line
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-03-13 19:23:52 +01:00
Mister Rajoy
18cd634ec8 Fix duplicated movies when group movies into collections is enabled 2021-02-28 23:03:28 +01:00
Bond_009
1c74e2f40e Fix build 2021-02-24 02:57:10 +01:00
Bond_009
119f64f5e7 Make some methods async 2020-08-21 22:01:19 +02:00
dkanada
83ae4d074d use constructor to set optimal config values 2020-06-27 00:22:27 +09:00
Patrick Barron
42b4f0aa2e Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Library/UserManager.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
crobibero
44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00
Patrick Barron
c464f700db Remove redundant qualifiers 2020-05-20 13:07:53 -04:00
Patrick Barron
9ad839c776 Initial migration code 2020-05-12 22:10:35 -04:00
Patrick Barron
7586c60224
Merge branch 'master' into warnings-cleanup1 2020-04-22 13:44:20 +00:00
Patrick Barron
c4e6329e58 Clean up and document ChannelManager.cs and implement suggestions 2020-04-15 15:00:45 -04:00
Patrick Barron
a54dca09d8 Added the last missing documentation 2020-04-14 19:34:38 -04:00
Patrick Barron
ddd8120aab Clean up and document CollectionManager.cs 2020-04-14 15:57:05 -04:00
Patrick Barron
77df0c943b Clean up and document CollectionImageProvider.cs 2020-04-14 15:50:48 -04:00
Bond_009
49fe5e0a21 Fix some warnings 2020-04-11 12:03:10 +02:00
Bond-009
94fe9b8f6d
Merge branch 'master' into warn17 2020-03-11 20:26:43 +01:00
Mark Monteiro
b67e9cde8c Replace ILogger with ILogger<T> wherever possible
Log entries will contain additional class context when using this interface
2020-03-03 23:07:10 +01:00
Bond_009
07cc4be6a7 Fix some warnings
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Bond_009
87d2479b78 Fix warnings 2020-01-31 22:26:53 +01:00
Bond_009
bb236b9591 Merge branch 'master' into warn12 2020-01-10 21:18:16 +01:00
Bond-009
49330e3082 Fix a couple of TODOs 2019-12-30 16:03:20 +01:00
Bond_009
2ef4ffd698 More warnings (removed) 2019-12-11 00:13:57 +01:00
dkanada
67922dff50
Merge pull request #2041 from Bond-009/warn11
Fix more warnings
2019-12-11 01:14:55 +09:00
Bond-009
a2c35e6dba Merge remote-tracking branch 'upstream/master' into random 2019-12-06 12:06:13 +01:00
Bond_009
42ffddc269 Fix more warnings 2019-11-27 16:29:56 +01:00
Bond-009
b477b3874e Fix some warnings 2019-11-22 16:15:31 +01:00
Bond_009
d9a03c9bb1 Fix more warnings 2019-10-29 17:55:16 +01:00
Bond_009
bbc0875387 Don't shuffle some types by default 2019-10-20 16:08:40 +02:00
Bond-009
6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
Bond-009
c5fce647de Cleanup/simplification
* Removed useless copies/allocations
* Reduced unneeded complexity
2019-03-07 21:13:13 +01:00