Commit Graph

1075 Commits

Author SHA1 Message Date
cvium
026a7af0e8 Don't throw when livestream file isn't found 2021-09-10 11:54:26 +02:00
cvium
6637a3096a Remove the dependency on BaseAuthorizationHandler 2021-09-10 11:44:50 +02:00
cvium
1a5a74d2a9 Remove more unused args 2021-09-10 10:03:42 +02:00
cvium
1603d1928e Kill ProgressiveFileCopier and seek to end for ongoing livetv 2021-09-10 09:29:14 +02:00
Bond-009
448125f2b4
Merge pull request #6523 from cvium/fix_livetv_cts_disposed 2021-09-09 13:46:26 +02:00
cvium
fdab8eebc9 Fix disposed exception when ffmpeg exits early in GetLiveHlsStream 2021-09-07 08:54:58 +02:00
Fernando Fernández
3d0b1ccae6
Remove all unused usings 2021-09-06 21:15:30 +02:00
Claus Vium
74fef6c05b
Merge pull request #6177 from Bond-009/async
Use async FileStreams where it makes sense
2021-09-06 13:55:34 +02:00
dkanada
5e3905d41a merge branch 'master' into syncplay-clear-queue 2021-09-06 13:35:58 +09:00
Bond-009
ff83fabac3
Merge pull request #6456 from GodTamIt/vp8-vp9
Disambiguate vpx to vp8 or vp9
2021-09-04 16:26:07 +02:00
Chris Tam
b205d5a032 Disambiguate vpx to vp8 or vp9 2021-09-04 07:36:17 -04:00
Cody Robibero
ff9d14c811 Merge remote-tracking branch 'upstream/master' into authenticationdb-efcore 2021-09-03 11:01:55 -06:00
Cody Robibero
ec13412155 Merge remote-tracking branch 'upstream/master' into warn-259810 2021-09-03 06:56:45 -06:00
Bond_009
e3dac4fda2 Use async FileStreams where it makes sense 2021-09-02 14:02:04 +02:00
Cody Robibero
cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
Bond_009
645825db36 Enable nullable for more files 2021-08-28 17:32:09 +02:00
cvium
f23ef1f1b9 Use ProgressiveFileStream for LiveRecordings endpoint 2021-08-17 13:38:28 +02:00
Patrick Barron
1615663bd2 Remove old response code documentation 2021-08-13 21:08:49 -04:00
Patrick Barron
45f478f63e Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
#	MediaBrowser.Controller/Library/IUserManager.cs
#	MediaBrowser.Controller/Security/IAuthenticationRepository.cs
#	MediaBrowser.Controller/Session/ISessionManager.cs
2021-08-13 21:08:24 -04:00
Claus Vium
5a9bd712b3
Merge pull request #6296 from Bond-009/oscheck
Improve platform checks
2021-07-23 20:54:13 +02:00
Bond-009
c22582b5aa
Merge pull request #6281 from crobibero/controller-warn-04 2021-07-20 21:24:08 +02:00
Bond-009
ea7c7ea48c
Merge pull request #5864 from DeeJayBro/return-on-error
Fix ArgumentOutOfRangeException when getting PostedPlaybackInfo
2021-07-17 20:54:07 +02:00
Cody Robibero
b44f191d54 Remove obsolete attribute, clean controller name 2021-07-16 08:58:04 -06:00
DeeJayBro
0ad62e7af9 Fix ArgumentOutOfRangeException when getting PostedPlaybackInfo 2021-07-16 11:48:08 +02:00
Patrick Barron
60ce0c9fa9 Add dto for device options 2021-07-13 19:30:11 -04:00
Cody Robibero
24c861c23b Remove extra endpoint 2021-07-12 17:22:01 -06:00
Bond_009
8528e9bddb Improve platform checks 2021-07-12 20:21:51 +02:00
Cody Robibero
65f8d8c0cd [CA1801] Parameter is never used. Remove the parameter or use it in the method body. 2021-07-10 10:09:02 -06:00
Cody Robibero
43b0d0fa95 Fix error message, use range parameters 2021-07-10 05:34:15 -06:00
Cody Robibero
e7022cc3fc Use asp validation and increase max size 2021-07-09 09:07:22 -06:00
Bill Thornton
3090971feb Restore max width and height params 2021-07-08 14:53:56 -04:00
Patrick Barron
bbac9ff67e GetDeviceOptions always returns an instance of DeviceOptions 2021-06-27 16:42:26 -04:00
crobibero
397868be95 Fix issues with QuickConnect and AuthenticationDb 2021-06-23 21:07:08 -06:00
Patrick Barron
ae878fa051 Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Emby.Server.Implementations/QuickConnect/QuickConnectManager.cs
#	Emby.Server.Implementations/Session/SessionManager.cs
#	Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
2021-06-23 20:22:12 -04:00
Claus Vium
a41065a248
Merge pull request #6200 from nielsvanvelzen/fix-quickconnect
Refactor Quick Connect
2021-06-22 09:43:14 +02:00
Niels van Velzen
7d46ca9317 Refactor Quick Connect 2021-06-22 09:13:14 +02:00
Patrick Barron
3123ea2a94 Add missing ConfigureAwait call 2021-06-19 15:09:16 -04:00
Bond_009
6f8ccab788 Move non-jellyfin extensions to separate project 2021-06-19 18:04:46 +02:00
BaronGreenback
6648b7d7da
Merge branch 'master' into comparisons 2021-06-19 15:04:30 +01:00
Patrick Barron
be88efce3c Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Devices/DeviceManager.cs
#	Emby.Server.Implementations/HttpServer/Security/SessionContext.cs
#	Emby.Server.Implementations/Security/AuthenticationRepository.cs
#	Emby.Server.Implementations/Session/SessionManager.cs
#	Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
#	MediaBrowser.Controller/Library/IUserManager.cs
#	MediaBrowser.Controller/Net/ISessionContext.cs
2021-06-18 18:56:10 -04:00
Patrick Barron
336ba2879f Re-add support for API keys 2021-06-18 18:26:58 -04:00
Bond-009
aaa9cc604f
Merge pull request #6176 from nielsvanvelzen/userid-required
Require userId in getItems and getTrailers endpoints
2021-06-13 15:06:30 +02:00
Niels van Velzen
226abde3f7 Change userId to required in operations that would otherwise throw exceptions 2021-06-12 16:19:34 +02:00
Niels van Velzen
0a0e10e854 Fix routeMediaSourceId route parameter in SubtitleController GetSubtitle 2021-06-12 15:38:13 +02:00
Cody Robibero
9154f20b34
Don't dispose managed CancellationTokenSource (#6139) 2021-06-04 14:36:58 +02:00
Claus Vium
6080093b51
Merge pull request #6094 from crobibero/album-artist-sort
Add sorting to /Artists/AlbumArtists
2021-05-27 07:23:34 +02:00
Claus Vium
61346dd2e2
Merge pull request #5828 from jackrvan/issue-5813
Add NextUpCutoffDate to NextUpQuery
2021-05-27 07:22:06 +02:00
Jack
accb974605 Add optional back 2021-05-26 22:49:53 -04:00
Jack
e3ff473bd4 Review notes to set value to Datetime min value instead of null 2021-05-25 20:46:29 -04:00
crobibero
e01ce826e0 Allow sorting for AlbumArtist 2021-05-23 08:38:05 -06:00
Bond-009
d61530eb4b
Merge pull request #6083 from Bond-009/nullable4
Enable nullable reference types for Emby.Server.Implementations
2021-05-21 13:05:03 +02:00
Patrick Barron
b6446c06ee Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Security/AuthenticationRepository.cs
#	Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
#	MediaBrowser.Controller/Devices/IDeviceManager.cs
2021-05-21 00:19:07 -04:00
Patrick Barron
a0c6f72762 Migrate authentication db to EF Core 2021-05-20 23:56:59 -04:00
Patrick Barron
ab63a7745c Add PaginatedQuery abstract class, change startIndex to skip 2021-05-20 20:48:41 -04:00
Patrick Barron
e1f7086077 Remove unnecessary query class 2021-05-20 20:39:22 -04:00
Bond-009
a937a854f2
Merge pull request #6013 from Bond-009/minor13 2021-05-21 01:29:36 +02:00
Bond_009
7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
Patrick Barron
a225f34796 Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Jellyfin.Api/Helpers/RequestHelpers.cs
2021-05-18 18:09:46 -04:00
Jack
7a17de84d9 Add optional to nextUpDateCutoff help text 2021-05-17 21:35:58 -04:00
Bond-009
50f617357b
Merge pull request #5929 from crobibero/sort 2021-05-11 12:41:25 +00:00
Cody Robibero
e3f55a0c54
Reduce warnings in MediaBrowser.Controller (#6006)
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-11 13:55:46 +02:00
BaronGreenback
97c2c523a8
Merge branch 'master' into comparisons 2021-05-08 17:11:21 +01:00
Bond_009
56ac64e70a Minor improvements
* properly dispose CancellationTokenSource
* rewrite DynamicHlsController.GetSegmentLengths
* remove dead code
2021-05-08 00:33:24 +02:00
Bond_009
fb090df0b5 Enable nullable reference types for MediaBrowser.Controller 2021-05-07 00:39:20 +02:00
Bond-009
a4a3f598af
Merge pull request #5982 from Bond-009/nullable 2021-05-06 23:33:41 +02:00
BaronGreenback
e682c230bd
Merge branch 'master' into comparisons 2021-05-05 23:22:54 +01:00
BaronGreenback
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? (#5845)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:51:14 +02:00
Bond_009
91c2a57b28 Enable nullable reference types for MediaBrowser.Common 2021-05-05 12:57:01 +02:00
Bond-009
9d3f614527
Merge pull request #5943 from Maxr1998/device-profile-defaults 2021-05-05 00:40:32 +02:00
crobibero
3c8abeda7d Require Authorization for the ClientLogController 2021-05-04 07:16:35 -06:00
Joshua M. Boniface
e71cd8274a
Merge pull request from GHSA-rgjw-4fwc-9v96
Remove /Images/Remote API endpoint
2021-05-02 16:53:36 -04:00
Joshua M. Boniface
3e4c860986 Remove /Items/RemoteSearch/Image API endpoint 2021-05-02 01:22:52 -04:00
Joshua M. Boniface
dc81d576ab Remove /Images/Remote API endpoint 2021-05-02 01:20:58 -04:00
Maxr1998
70771fdcd6
Nullability handling for device profile classes 2021-05-01 13:06:10 +02:00
Maxr1998
e90fbe90f9
Remove extraneous 'stream' parameter
The argument isn't passed to the method but causes the API generator to include an unnecessary parameter.
Also fixes some typos in the documentation comments.
2021-04-30 15:07:27 +02:00
Cody Robibero
69e91c33d8
Update Jellyfin.Api/Controllers/GenresController.cs 2021-04-29 04:10:26 -06:00
crobibero
d27ca993a5 Add ability to sort on Genre, MusicGenre, Artist 2021-04-28 18:33:30 -06:00
crobibero
1d6224c9c6 Add endpoint to log client events 2021-04-26 07:02:26 -06:00
Bond-009
224c48821e
Merge pull request #5887 from Bond-009/perf
Improve perf of db save and query
2021-04-24 15:57:51 +02:00
crobibero
856819e58f Don't use obsolete Password property 2021-04-22 06:49:42 -06:00
Bond_009
f46195899e Improve perf of db save and query 2021-04-21 22:25:08 +02:00
Bond_009
499bac5185 EncodingHelper: Fix circular dependency 2021-04-20 23:03:36 +02:00
BaronGreenback
bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
BaronGreenback
80877aa945 Cleaned up "value assigned is not used in any execution path" 2021-04-17 09:27:58 +01:00
Jack
198cc6e76a Some code cleanup. Allow NextUpDateCutoff to be null 2021-04-16 13:57:22 -04:00
Jack
d7855500c2 Add NextUpCutoffDate to NextUpQuery 2021-04-15 14:48:21 -04:00
Claus Vium
dc4714fe40
fix webp compatibility testing (#5787) 2021-04-12 19:54:32 +02:00
Cody Robibero
cc59abd54e
Mark cropWhitespace parameter as obsolete (#5751) 2021-04-12 15:50:24 +02:00
Joshua M. Boniface
770c123d12
Merge pull request #5764 from cvium/fix-folders-perms
Do not check permissions for Folders collectiontype
2021-04-11 13:30:15 -04:00
Odd Stråbø
13d0837b78 (mostly)Fix ResizeFill 2021-04-11 08:21:23 +02:00
Odd Stråbø
383aa4e4d9 Add Resize to fill box alternative to image endpoints 2021-04-11 08:20:47 +02:00
cvium
f2e7491755 Do not check permissions for Folders collectiontype 2021-04-10 22:58:32 +02:00
Patrick Barron
8607b52541 Make device/session code async 2021-04-10 16:57:25 -04:00
Patrick Barron
44e71774b1 Rewrite device manager using EF Core 2021-04-10 16:17:36 -04:00
Bond-009
b2fbf97abd
Merge pull request #4988 from Bond-009/crop 2021-04-10 02:57:43 +02:00
Claus Vium
a1718e392b
Merge pull request #5631 from BrianCArnold/FixMessageCommand 2021-04-07 14:36:08 +02:00
Bond-009
4f387dca6e
Merge pull request #5598 from cvium/fix_hls_default_values 2021-04-03 19:36:41 +02:00
Bond-009
ec0ef1530c
Merge pull request #5602 from Ullmie02/IP-string-IP 2021-04-03 00:32:43 +02:00
Patrick Barron
499785bebb Use new entities for API key endpoints 2021-04-01 17:08:22 -04:00
BrianCArnold
4fa2a32d81
Apply suggestions from code review
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-31 01:24:38 -04:00
BrianCArnold
af03b280bc
Update SessionController.cs 2021-03-31 01:23:51 -04:00
BrianCArnold
80fe48fda9
Update SessionController.cs
Removed unnecessary construction of POCO to represent data from POST body
2021-03-30 07:29:40 -04:00
Brian Arnold
ca25301e64 Added Required attribute to Text property of MessageCommand. 2021-03-29 10:10:44 -04:00
Brian C. Arnold
998833ea6e Removed null check for body object and user [Required] attribute in replacement. 2021-03-27 23:29:24 -04:00
Brian Arnold
f114ba57dd Fixed comment and code block runes to match coding
standards required by Jellyfin team.
2021-03-27 23:29:24 -04:00
Brian Arnold
81e3e5ca48 Changed SessionController.SendMessageCommand
implementation receive data in the POST body, as that is how the
jellyfin-web client currently posts the data to the server.

Resolves: #5628
2021-03-27 23:29:24 -04:00
Claus Vium
9144d11a9d
Merge pull request #5624 from crobibero/subtitle-format 2021-03-27 09:25:34 +01:00
crobibero
afe3b5999e Fix route naming 2021-03-26 17:40:55 -06:00
lmaonator
694d772b11
Update Jellyfin.Api/Controllers/SessionController.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-03-26 14:13:45 +01:00
crobibero
5b758c4711 Mark query parameters as obsolete 2021-03-26 07:07:45 -06:00
lmaonator
db2fbcef2b Fix stream selection having no effect when casting
When casting to jellyfin-mpv-shim from jellyfin-web in the browser,
jellyfin-web sends data about which version (for grouped items) and
which streams the user selected in the browser to the
"Sessions/{sessionId}/Playing" API endpoint.

The API endpoint currently doesn't forward them to jellyfin-mpv-shim
through the Play command, which results in the default streams being
played instead of the browser selected ones.

PlayRequest already has the properties and they are already sent to the
cast client by SendPlayCommand when present.
jellyfin-mpv-shim will already use them to select the wanted streams
when it receives the Play command.

All that's needed to make it work is to take the parameters and assign
them to PlayRequest.
2021-03-26 13:41:34 +01:00
crobibero
e0ff51cf2a Mark query parameters as obsolete 2021-03-25 20:30:15 -06:00
crobibero
73fe9d3f69 Allow subtitle format to be set from query parameter. 2021-03-25 18:06:25 -06:00
cvium
b3d084044e enable range processing for download endpoints 2021-03-25 15:09:37 +01:00
David
19e4ef82dd Remove conversion from IPAddress to string to IPAddress 2021-03-23 17:16:10 +01:00
cvium
7dedeb6c79 change HLS endpoint defaults to false 2021-03-22 20:53:55 +01:00
Erwin de Haan
1f3aa3fe6f Apply review suggestions 2021-03-20 01:28:14 +01:00
Erwin de Haan
239a7156cc Fix arbitrary image file reads in ImageByNameController
GHSL-2021-050: Issue 4 Arbitrary image file read and directory traversal.
2021-03-20 01:14:59 +01:00
Erwin de Haan
f61d18612b Fix directory traversal in the HlsSegmentController in a fairly rudimentary but working way.
GHSL-2021-050: Issue 1,2,3 Arbitrary file read and directory traversal.
The segment id's can probably just be verified to be an actual ID or to not contain any forward or backward slashes
2021-03-20 01:14:59 +01:00
Patrick Barron
e5380c653b Merge branch 'master' into ef-cleanup
# Conflicts:
#	Jellyfin.Data/Entities/Libraries/MediaFileStream.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2021-03-14 10:19:35 -04:00
Bond-009
0e5d4a3bcf
Merge pull request #5422 from Bond-009/warn51 2021-03-14 00:41:40 +01:00
Bond-009
8bb2420a25
Merge pull request #5518 from crobibero/missing-endpoints
Add missing InstantMix endpoints
2021-03-13 22:59:47 +01:00
Bond_009
a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
crobibero
9ac9543ee2 Add missing InstantMix endpoints 2021-03-13 09:09:22 -07:00
Bond-009
260b48ef9d
Merge pull request #5515 from jellyfin/fix-refresh-endpoint
fix refresh endpoint
2021-03-13 15:07:42 +01:00
Claus Vium
fe2a310fe2
fix refresh endpoint
It was originally a POST 9af6eda0b4/MediaBrowser.Api/Library/LibraryService.cs (L155)
2021-03-13 09:13:45 +01:00
crobibero
eef15dc7ac Fix third part integration 2021-03-11 22:45:58 -07:00
David
60ffa6f514 Use FileShare.None when creating files 2021-03-07 14:43:28 +01:00
Patrick Barron
f638ee6b09 Enable nullable for Jellyfin.Data and remove unnecessary attributes 2021-03-06 17:43:01 -05:00
Bond-009
e839929b91
Merge pull request #5380 from Bond-009/plugins
100% branch coverage for DashboardController
2021-03-06 00:59:28 +01:00
Bond-009
3741be51ec
Merge pull request #5383 from cvium/fix-mergeversions-overflow
do not pick a linked item as primary when merging versions
2021-03-05 21:57:22 +01:00
cvium
59814bd55e do not pick a linked item as primary when merging versions 2021-03-05 19:57:48 +01:00
Claus Vium
d0a2d00b29
Fix UpdateMediaPath model binding (#5378) 2021-03-05 16:56:21 +01:00
Bond_009
a6d0db5d04 100% branch coverage for DashboardController 2021-03-05 11:15:14 +01:00
crobibero
858c91ab48 Specify defaults or set query parameter to nullable 2021-03-04 18:25:52 -07:00
Bond_009
914e891689 Fix unchecked input 2021-02-24 02:05:12 +01:00
Joshua M. Boniface
7ece3c5523
Merge pull request #5273 from Bond-009/warn31 2021-02-22 21:00:46 -05:00
Bond_009
ec3237ba55 Fix tests 2021-02-22 13:46:40 +01:00
Bond_009
57102090d3 Add tests for DashboardController 2021-02-22 13:15:29 +01:00
Bond_009
40b9e7592f Fix build 2021-02-20 23:34:15 +01:00
dkanada
13d65318eb
Merge pull request #5223 from Bond-009/minor10
Minor improvements
2021-02-20 10:56:55 +09:00
Bond_009
65bab55ca0 Minor improvements 2021-02-13 00:39:18 +01:00
dkanada
9fcdbd4c4b remove deprecated settings from server config 2021-02-12 21:58:37 +09:00
Bond-009
76d66e0dee
Merge pull request #5208 from crobibero/api-post-image
Add image file accept to openapi
2021-02-11 17:42:28 +01:00
crobibero
223b42aed3 Create BaseItemKind enum 2021-02-10 17:09:23 -07:00
crobibero
d5f0b046bb Add image file accept to openapi 2021-02-10 16:12:52 -07:00
David Ullmer
07f1a2c2dc
Update Jellyfin.Api/Controllers/UserController.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-02-06 18:36:18 +01:00
David
eb0ff0c370 Fix forgot password pin request 2021-02-06 17:18:37 +01:00
dkanada
86859a3926
Merge pull request #5010 from BaronGreenback/Remove_IPluginConfigurationPage
Removal of IPluginConfigurationPage
2021-02-05 11:38:44 +09:00
Bond-009
4a2678e63b
Merge pull request #5097 from Bond-009/cleanup4
Remove useless abstraction and clean up formatting
2021-01-26 17:44:49 +01:00