Commit Graph

1183 Commits

Author SHA1 Message Date
Joshua M. Boniface
e71cd8274a
Merge pull request from GHSA-rgjw-4fwc-9v96
Remove /Images/Remote API endpoint
2021-05-02 16:53:36 -04:00
Joshua M. Boniface
3e4c860986 Remove /Items/RemoteSearch/Image API endpoint 2021-05-02 01:22:52 -04:00
Joshua M. Boniface
dc81d576ab Remove /Images/Remote API endpoint 2021-05-02 01:20:58 -04:00
Maxr1998
70771fdcd6
Nullability handling for device profile classes 2021-05-01 13:06:10 +02:00
cvium
ba2e346d12 prevent cancellationtoken leakage 2021-04-30 15:27:07 +02:00
Maxr1998
e90fbe90f9
Remove extraneous 'stream' parameter
The argument isn't passed to the method but causes the API generator to include an unnecessary parameter.
Also fixes some typos in the documentation comments.
2021-04-30 15:07:27 +02:00
Bond-009
eeb5d4bd1e
Merge pull request #5842 from BaronGreenback/optimization
Code Clean up: Group Methods
2021-04-29 21:14:57 +02:00
Cody Robibero
69e91c33d8
Update Jellyfin.Api/Controllers/GenresController.cs 2021-04-29 04:10:26 -06:00
crobibero
d27ca993a5 Add ability to sort on Genre, MusicGenre, Artist 2021-04-28 18:33:30 -06:00
dependabot[bot]
a3cb8dbc9d
Bump Swashbuckle.AspNetCore.ReDoc from 6.0.7 to 6.1.3
Bumps [Swashbuckle.AspNetCore.ReDoc](https://github.com/domaindrivendev/Swashbuckle.AspNetCore) from 6.0.7 to 6.1.3.
- [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases)
- [Commits](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/compare/v6.0.7...v6.1.3)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-26 21:47:14 +00:00
dependabot[bot]
d5037a8988
Bump Swashbuckle.AspNetCore from 6.0.7 to 6.1.3
Bumps [Swashbuckle.AspNetCore](https://github.com/domaindrivendev/Swashbuckle.AspNetCore) from 6.0.7 to 6.1.3.
- [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases)
- [Commits](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/compare/v6.0.7...v6.1.3)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-26 12:00:48 +00:00
Bond-009
224c48821e
Merge pull request #5887 from Bond-009/perf
Improve perf of db save and query
2021-04-24 15:57:51 +02:00
Bond-009
1a54338e38
Merge pull request #5892 from crobibero/password-obsolete 2021-04-23 10:17:49 +02:00
Bond-009
184e05aeb6
Merge pull request #5681 from BaronGreenback/ContentFeatureOptimization
Various DLNA Optimizations
2021-04-22 16:45:36 +02:00
crobibero
856819e58f Don't use obsolete Password property 2021-04-22 06:49:42 -06:00
crobibero
5b0dc21c64 Mark password property as obsolete 2021-04-21 20:46:15 -06:00
Bond_009
f46195899e Improve perf of db save and query 2021-04-21 22:25:08 +02:00
Bond-009
d5163b4167
Merge pull request #5877 from Bond-009/circ1
EncodingHelper: Fix circular dependency
2021-04-21 15:49:17 +02:00
Bond_009
499bac5185 EncodingHelper: Fix circular dependency 2021-04-20 23:03:36 +02:00
cvium
8933389753 Respect user settings for transcode and remux 2021-04-19 10:49:52 +02:00
BaronGreenback
bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
BaronGreenback
bb6fddde9a Group Methods 2021-04-17 11:19:09 +01:00
Jack
198cc6e76a Some code cleanup. Allow NextUpDateCutoff to be null 2021-04-16 13:57:22 -04:00
Jack
d7855500c2 Add NextUpCutoffDate to NextUpQuery 2021-04-15 14:48:21 -04:00
Claus Vium
dc4714fe40
fix webp compatibility testing (#5787) 2021-04-12 19:54:32 +02:00
Cody Robibero
cc59abd54e
Mark cropWhitespace parameter as obsolete (#5751) 2021-04-12 15:50:24 +02:00
Joshua M. Boniface
770c123d12
Merge pull request #5764 from cvium/fix-folders-perms
Do not check permissions for Folders collectiontype
2021-04-11 13:30:15 -04:00
Odd Stråbø
13d0837b78 (mostly)Fix ResizeFill 2021-04-11 08:21:23 +02:00
Odd Stråbø
383aa4e4d9 Add Resize to fill box alternative to image endpoints 2021-04-11 08:20:47 +02:00
Claus Vium
bf510ca04e
Merge pull request #5750 from iwalton3/fix-audio-selection-uns
Fix setting audio stream in PlaybackInfo for jellyfin-web.
2021-04-10 23:10:16 +02:00
cvium
f2e7491755 Do not check permissions for Folders collectiontype 2021-04-10 22:58:32 +02:00
Bond-009
b2fbf97abd
Merge pull request #4988 from Bond-009/crop 2021-04-10 02:57:43 +02:00
Ian Walton
321e383965 Fix setting audio stream in PlaybackInfo for jellyfin-web. 2021-04-09 19:24:41 -04:00
Bond-009
5042246360
Merge pull request #5710 from jellyfin/dependabot/nuget/Microsoft.AspNetCore.Authorization-5.0.5
Bump Microsoft.AspNetCore.Authorization from 5.0.3 to 5.0.5
2021-04-07 17:42:27 +02:00
Claus Vium
a1718e392b
Merge pull request #5631 from BrianCArnold/FixMessageCommand 2021-04-07 14:36:08 +02:00
dependabot[bot]
e85ac4d975
Bump Microsoft.AspNetCore.Authorization from 5.0.3 to 5.0.5
Bumps [Microsoft.AspNetCore.Authorization](https://github.com/dotnet/aspnetcore) from 5.0.3 to 5.0.5.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.3...v5.0.5)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-06 18:35:36 +00:00
Bond-009
4f387dca6e
Merge pull request #5598 from cvium/fix_hls_default_values 2021-04-03 19:36:41 +02:00
Bond-009
ec0ef1530c
Merge pull request #5602 from Ullmie02/IP-string-IP 2021-04-03 00:32:43 +02:00
BaronGreenback
d9a50cb510 Various DLNA Optimizations 2021-04-02 19:06:38 +01:00
BrianCArnold
4fa2a32d81
Apply suggestions from code review
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-31 01:24:38 -04:00
BrianCArnold
af03b280bc
Update SessionController.cs 2021-03-31 01:23:51 -04:00
BrianCArnold
80fe48fda9
Update SessionController.cs
Removed unnecessary construction of POCO to represent data from POST body
2021-03-30 07:29:40 -04:00
Brian Arnold
ca25301e64 Added Required attribute to Text property of MessageCommand. 2021-03-29 10:10:44 -04:00
Brian C. Arnold
998833ea6e Removed null check for body object and user [Required] attribute in replacement. 2021-03-27 23:29:24 -04:00
Brian Arnold
f114ba57dd Fixed comment and code block runes to match coding
standards required by Jellyfin team.
2021-03-27 23:29:24 -04:00
Brian Arnold
81e3e5ca48 Changed SessionController.SendMessageCommand
implementation receive data in the POST body, as that is how the
jellyfin-web client currently posts the data to the server.

Resolves: #5628
2021-03-27 23:29:24 -04:00
Claus Vium
9144d11a9d
Merge pull request #5624 from crobibero/subtitle-format 2021-03-27 09:25:34 +01:00
crobibero
afe3b5999e Fix route naming 2021-03-26 17:40:55 -06:00
lmaonator
694d772b11
Update Jellyfin.Api/Controllers/SessionController.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-03-26 14:13:45 +01:00
crobibero
5b758c4711 Mark query parameters as obsolete 2021-03-26 07:07:45 -06:00
lmaonator
db2fbcef2b Fix stream selection having no effect when casting
When casting to jellyfin-mpv-shim from jellyfin-web in the browser,
jellyfin-web sends data about which version (for grouped items) and
which streams the user selected in the browser to the
"Sessions/{sessionId}/Playing" API endpoint.

The API endpoint currently doesn't forward them to jellyfin-mpv-shim
through the Play command, which results in the default streams being
played instead of the browser selected ones.

PlayRequest already has the properties and they are already sent to the
cast client by SendPlayCommand when present.
jellyfin-mpv-shim will already use them to select the wanted streams
when it receives the Play command.

All that's needed to make it work is to take the parameters and assign
them to PlayRequest.
2021-03-26 13:41:34 +01:00
crobibero
e0ff51cf2a Mark query parameters as obsolete 2021-03-25 20:30:15 -06:00
crobibero
73fe9d3f69 Allow subtitle format to be set from query parameter. 2021-03-25 18:06:25 -06:00
cvium
b3d084044e enable range processing for download endpoints 2021-03-25 15:09:37 +01:00
Szymon Acedański
b1e8a8565f
Update Jellyfin.Api/Helpers/FileStreamResponseHelpers.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-24 22:46:08 +01:00
Szymon Acedański
136136dea9 Fix incorrect responses for HEAD /audio/<id>/stream
Without this fix my Samsung Soundbar (HW-Q80R) fails to play using DLNA
and returns "Error: Resource not found (716)" instead.

I had a look on tcpdump network logs between Jellyfin and the soundbar
and noticed that the device performs a HEAD request for the media before
responding to the DLNA UPNP control request from Jellyfin (or BubbleUPNP
Android App).

Jellyfin retuns 204 No Content response, which is unusual.  Common web
servers generally return 200 OK if the GET would return content, and
this is not-very-clearly suggested [in HTTP
spec](https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.1)

The other patch is to ensure, that invalid Content-Length: 0 is not
returned with the HEAD response in the streaming case.

I think in both cases we still don't return the same headers with HEAD
as with GET (e.g. Content-Length or Accept-Ranges), but at least we
don't return anything misleading.
2021-03-24 20:43:54 +01:00
David
19e4ef82dd Remove conversion from IPAddress to string to IPAddress 2021-03-23 17:16:10 +01:00
cvium
7dedeb6c79 change HLS endpoint defaults to false 2021-03-22 20:53:55 +01:00
Erwin de Haan
1f3aa3fe6f Apply review suggestions 2021-03-20 01:28:14 +01:00
Erwin de Haan
239a7156cc Fix arbitrary image file reads in ImageByNameController
GHSL-2021-050: Issue 4 Arbitrary image file read and directory traversal.
2021-03-20 01:14:59 +01:00
Erwin de Haan
f61d18612b Fix directory traversal in the HlsSegmentController in a fairly rudimentary but working way.
GHSL-2021-050: Issue 1,2,3 Arbitrary file read and directory traversal.
The segment id's can probably just be verified to be an actual ID or to not contain any forward or backward slashes
2021-03-20 01:14:59 +01:00
Patrick Barron
e5380c653b Merge branch 'master' into ef-cleanup
# Conflicts:
#	Jellyfin.Data/Entities/Libraries/MediaFileStream.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2021-03-14 10:19:35 -04:00
Bond-009
0e5d4a3bcf
Merge pull request #5422 from Bond-009/warn51 2021-03-14 00:41:40 +01:00
Bond-009
8bb2420a25
Merge pull request #5518 from crobibero/missing-endpoints
Add missing InstantMix endpoints
2021-03-13 22:59:47 +01:00
Bond_009
a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
crobibero
9ac9543ee2 Add missing InstantMix endpoints 2021-03-13 09:09:22 -07:00
Bond-009
260b48ef9d
Merge pull request #5515 from jellyfin/fix-refresh-endpoint
fix refresh endpoint
2021-03-13 15:07:42 +01:00
Claus Vium
fe2a310fe2
fix refresh endpoint
It was originally a POST 9af6eda0b4/MediaBrowser.Api/Library/LibraryService.cs (L155)
2021-03-13 09:13:45 +01:00
crobibero
eef15dc7ac Fix third part integration 2021-03-11 22:45:58 -07:00
Claus Vium
5592967497
Merge pull request #5403 from BaronGreenback/DLNAProfileFix 2021-03-10 11:50:08 +01:00
BaronGreenback
84da57cd48
Update StreamingHelpers.cs
Updated condition
2021-03-10 09:07:11 +00:00
David
ece0d67f99 Use FileShare.Read for log files 2021-03-09 17:31:31 +01:00
Bond_009
9ed7f429c0 FxCop -> Net Analyzers (part 1) 2021-03-09 03:04:47 +01:00
BaronGreenback
75c9659e05 Fix unreachable code & assign id to each profile. 2021-03-07 14:17:32 +00:00
David
60ffa6f514 Use FileShare.None when creating files 2021-03-07 14:43:28 +01:00
Patrick Barron
f638ee6b09 Enable nullable for Jellyfin.Data and remove unnecessary attributes 2021-03-06 17:43:01 -05:00
Bond-009
e839929b91
Merge pull request #5380 from Bond-009/plugins
100% branch coverage for DashboardController
2021-03-06 00:59:28 +01:00
Bond-009
3741be51ec
Merge pull request #5383 from cvium/fix-mergeversions-overflow
do not pick a linked item as primary when merging versions
2021-03-05 21:57:22 +01:00
cvium
59814bd55e do not pick a linked item as primary when merging versions 2021-03-05 19:57:48 +01:00
Claus Vium
d0a2d00b29
Fix UpdateMediaPath model binding (#5378) 2021-03-05 16:56:21 +01:00
Bond_009
a6d0db5d04 100% branch coverage for DashboardController 2021-03-05 11:15:14 +01:00
crobibero
858c91ab48 Specify defaults or set query parameter to nullable 2021-03-04 18:25:52 -07:00
BaronGreenback
d819a1d928
Remove Content-Length header from DLNA HEAD request (#5335) 2021-03-03 15:41:18 +01:00
Bond-009
c2af32d035
Merge pull request #5299 from Bond-009/tests13 2021-03-01 18:51:09 +01:00
Bond_009
914e891689 Fix unchecked input 2021-02-24 02:05:12 +01:00
Bond_009
aff0aea60f Improve branch coverage 2021-02-23 14:14:02 +01:00
Joshua M. Boniface
7ece3c5523
Merge pull request #5273 from Bond-009/warn31 2021-02-22 21:00:46 -05:00
Joshua M. Boniface
c0c4aff8a6
Merge pull request #5276 from Bond-009/minor12 2021-02-22 21:00:34 -05:00
Joshua M. Boniface
da55462d92
Merge pull request #5291 from Bond-009/tests12 2021-02-22 21:00:15 -05:00
dependabot[bot]
875e02318c
Bump Swashbuckle.AspNetCore from 6.0.5 to 6.0.7
Bumps [Swashbuckle.AspNetCore](https://github.com/domaindrivendev/Swashbuckle.AspNetCore) from 6.0.5 to 6.0.7.
- [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases)
- [Commits](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/compare/v6.0.5...v6.0.7)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-22 16:11:56 +00:00
Bond_009
ec3237ba55 Fix tests 2021-02-22 13:46:40 +01:00
Bond_009
57102090d3 Add tests for DashboardController 2021-02-22 13:15:29 +01:00
dependabot[bot]
29fb2c57c8
Bump Swashbuckle.AspNetCore.ReDoc from 6.0.5 to 6.0.7
Bumps [Swashbuckle.AspNetCore.ReDoc](https://github.com/domaindrivendev/Swashbuckle.AspNetCore) from 6.0.5 to 6.0.7.
- [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases)
- [Commits](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/compare/v6.0.5...v6.0.7)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-22 12:00:48 +00:00
Bond_009
b1fe28d0a6 Use GetEncodingOptions where possible 2021-02-21 02:58:30 +01:00
Bond_009
eba859e33e Minor improvements 2021-02-21 02:49:52 +01:00
Bond_009
40b9e7592f Fix build 2021-02-20 23:34:15 +01:00
Bond_009
141efafd3d Enable TreatWarningsAsErrors for MediaBrowser.Model 2021-02-20 23:29:33 +01:00
dkanada
13d65318eb
Merge pull request #5223 from Bond-009/minor10
Minor improvements
2021-02-20 10:56:55 +09:00
dkanada
175e2a5249
Merge pull request #5242 from jellyfin/cancellationtokens
Properly forward cancellationTokens
2021-02-20 10:52:30 +09:00
crobibero
6ad2544a30 Bump Swashbuckle.AspNetCore to 6.0.5 2021-02-15 10:07:50 -07:00