Jonas Resch
e18d966874
Add "Async" suffix to AddExternalAudio method
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-12-08 16:49:20 +01:00
Jonas Resch
4cdb590291
Exclude .strm files when searching for external audio files
2021-12-08 10:18:09 +01:00
Jonas Resch
01a0a4a87c
Add audioResolver argument to FFProbeVideoInfo initialization
2021-12-08 10:16:48 +01:00
Jonas Resch
87a6fdf847
Merge branch 'support-external-audio-files' of github.com:jonas-resch/jellyfin into support-external-audio-files
2021-12-08 09:55:16 +01:00
Claus Vium
a327b43ab7
Update MediaBrowser.Providers/MediaInfo/FFProbeProvider.cs
2021-12-07 20:28:51 +01:00
Claus Vium
3f69eeab27
Merge branch 'master' into support-external-audio-files
2021-12-07 20:16:32 +01:00
Cody Robibero
9cea773d29
Merge pull request #6874 from 1337joe/tmdb-image-size-options
2021-12-03 07:03:02 -07:00
cvium
5535b9c01f
Reduce allocations
2021-12-02 11:21:59 +01:00
Jonas Resch
180e2dc329
Prevent crashes in specific scenarios
2021-12-01 21:05:43 +01:00
Jonas Resch
6bbfcf1906
Add documentation to AudioResolver class
2021-11-30 21:05:43 +01:00
Jonas Resch
7b50048020
Add ConfigureAwait true in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 20:45:47 +01:00
Jonas Resch
a9a53dc657
Add ConfigureAwait true in MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 20:45:21 +01:00
Jonas Resch
0d8170cedb
Move variable in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 20:44:57 +01:00
Jonas Resch
1a35690834
Don't disable warnings in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 20:44:16 +01:00
Jonas Resch
c61b9ef05a
Fix warning due to new line after opening bracket
2021-11-30 19:52:44 +01:00
Jonas Resch
b5b994b22f
Fix compiler warning due to missing EnumeratorCancellation attribute
2021-11-30 19:31:46 +01:00
Jonas Resch
0894a6193f
Implement coding standards from 2nd code feedback
2021-11-30 19:31:46 +01:00
Jonas Resch
9d34d6339a
Change return type from List<string> to IEnumerable<string> in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
bbf1399826
Check language for null or empty instead of only null in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
d016d483ae
Change return type from Task<List<MediaStream>> to Task<IAsyncEnumerable<MediaStream>> in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
61b191d345
Fix indentation in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
If statement which checks if filename of audio and video file match or if audio file starts with video filename
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
9433072f90
Only search in video folder for external audio files
...
Don't search in video metadata folder since audio files won't be stored there
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
a3c5afa443
Add ConfigureAwait false MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-11-30 19:31:46 +01:00
Jonas Resch
f1862f9b1a
Add ConfigureAwait false to MediaBrowser.Providers/MediaInfo/AudioResolver.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-11-30 19:31:46 +01:00
Jonas Resch
a68e58556c
Implement code feedback
...
- Rewrite AudioResolver
- Use async & await instead of .Result
- Add support for audio containers with multiple audio streams (e.g.
mka)
- Fix bug when using external subtitle and external audio streams at the
same time
2021-11-30 19:31:46 +01:00
Jonas Resch
c1a8385c9c
Shorten calculation of audio startIndex in MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-30 19:31:46 +01:00
Jonas Resch
9978164438
Add support for external audio files
2021-11-30 19:31:46 +01:00
Joe Rogers
e778462955
Use SSL for tmdb images
2021-11-30 14:31:32 +01:00
Bond-009
2a09d4244c
Merge pull request #6923 from cvium/query_a_bit_less
2021-11-29 13:00:38 +01:00
cvium
beef6f0855
Don't query series twice
2021-11-28 19:56:31 +01:00
Joe Rogers
1df5b5034b
Address suppressed warnings
2021-11-27 20:35:18 +01:00
Joe Rogers
4a20ae6cb4
Allow default/forced tag without setting language
2021-11-27 20:13:21 +01:00
Joe Rogers
0af5e60094
Address review comments
...
Store null instead of calculating scaled image sizes.
Add endpoint to provide TMDb image size options.
2021-11-22 21:08:07 +01:00
Cody Robibero
b2b4bd82d7
Merge pull request #6862 from 1337joe/query-instead-of-filtering
2021-11-20 08:50:39 -07:00
cvium
71a0abe211
Remove unnecessary N/A checks (converter changes them to null)
2021-11-20 08:32:07 +01:00
cvium
d8c3b8e7f8
Don't use AppendFormat
2021-11-20 08:24:52 +01:00
Joe Rogers
88baff5693
Apply suggestions from code review
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-11-19 22:40:42 +01:00
Joe Rogers
6d3b129666
Add image scaling options for tmdb
2021-11-19 22:21:21 +01:00
cvium
96ea865681
Refactor omdb providers
2021-11-19 15:32:07 +01:00
Joe Rogers
9ba7bf96ef
Query MediaSourceManager directly in image providers
...
Add doc comments/minor tweaks to AudioImageProvider
2021-11-18 15:11:50 +01:00
Joe Rogers
7cf5767949
Query media streams by type instead of filtering
2021-11-17 22:34:04 +01:00
Cody Robibero
fa366f0099
Merge pull request #6860 from cvium/fix_xml_endless_loops
2021-11-17 08:39:49 -07:00
cvium
61b75c82ce
Read past empty elements
2021-11-17 14:49:30 +01:00
cvium
24024706bf
Fix release build
2021-11-16 12:55:35 +01:00
cvium
93fd1c7075
Fix
2021-11-16 12:27:27 +01:00
cvium
b50c3852ef
Remove unused dependencies
2021-11-16 12:24:17 +01:00
Cody Robibero
4cfe8fe588
Merge pull request #6831 from 1337joe/image-provider-cleanup
2021-11-15 15:45:33 -07:00
Joe Rogers
f059be8e4d
Add logging and fast return
2021-11-15 15:30:43 +01:00
Joe Rogers
370b7f8e12
Handle unexpected case more gracefully
2021-11-14 23:13:45 +01:00
Joe Rogers
1d729b2b0f
Use codec to determine image format
2021-11-12 16:30:30 +01:00
Joe Rogers
f73a7a6ed8
Use ImageFormat instead of string for extension
2021-11-12 16:22:11 +01:00
Cody Robibero
14c072dd32
Fix filtering images without dimensions
2021-11-12 07:21:46 -07:00
Joe Rogers
de9bf327c6
Merge similar tests with Theories
2021-11-12 13:44:48 +01:00
Bond_009
5726535a26
Fix some warnings
...
609 left
2021-11-09 13:14:31 +01:00
Cody Robibero
64652b6392
Fix and disable new dotnet6 warnings
2021-11-08 12:40:52 -07:00
Cody Robibero
40045d2147
Update to full dotnet 6
2021-11-08 09:40:12 -07:00
Joe Rogers
b4bf5af7c8
Remove ImageType.Screenshot and ItemFields.Screenshot
2021-11-06 20:43:20 +01:00
Joe Rogers
c8eba90c17
Add cast limit to tmdb plugin settings
2021-11-05 00:38:50 +01:00
Joe Rogers
6c76d30538
Add missing checkboxes
2021-11-04 23:58:32 +01:00
Bond_009
924c6682b9
Remove unused IHasScreenshots interface
2021-11-04 01:06:21 +01:00
Claus Vium
5c5d49ee60
Merge pull request #6763 from 1337joe/tmdb-image-provider-dedup
2021-11-04 00:22:08 +01:00
Joe Rogers
4fc0521d69
Move ConvertToRemoteImage to TmdbClientManager
2021-11-03 17:16:40 +01:00
Claus Vium
869d537aaa
Merge pull request #6752 from 1337joe/fix-metadata-refresh-deletes-backgrounds
2021-11-03 13:01:23 +01:00
Joe Rogers
2b283d249f
Switch to method per image conversion
2021-11-02 21:12:13 +01:00
Joe Rogers
7fcf01235c
Change RemoveImages to array, improve download test
2021-11-02 16:16:06 +01:00
zehner
3d858955b6
Make tags import from TMDB configurable
...
new settings added
2021-11-02 15:11:01 +01:00
Joe Rogers
7da6bd905a
Fix edge case in multi-image replacing
2021-11-02 00:31:59 +01:00
Joe Rogers
4a5e8b99a0
Extract duplicate code, add test
2021-11-01 23:17:00 +01:00
Joe Rogers
b478b115e3
Refactor to validate all images up front
2021-11-01 11:53:31 +01:00
Joe Rogers
0fbd8d85c8
Validate multi-images, lazy-delete bg on refresh
...
Fix failing test: Invalid background images not purged by validate
Fixes #6310 : Background images only delete when using "Replace existing images" when new image(s) is found to replace them
2021-11-01 00:16:11 +01:00
Joe Rogers
080b02cc4c
Add comments, minor cleanup, add tests
2021-10-31 23:56:50 +01:00
Bond_009
f5ca9cbc3b
Enable nullable for MediaBrowser.Providers
2021-10-26 15:49:01 +02:00
Claus Vium
768ec60e11
Merge pull request #6689 from 1337joe/expand-image-extraction
2021-10-21 23:05:32 +02:00
Joe Rogers
31baea072a
Address review comments
...
Clean up style
Fix references in class summaries
Combine Where+FirstOrDefault queries
Break up large method, long lines
Add validation on file extension
Apply test naming conventions
Extract mock of Movie class, comment on why not mocking interface
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-10-20 14:10:16 +02:00
MBR-0001
ade3afad41
Add IsAutomated to SubtitleSearchRequest
2021-10-19 21:06:05 +02:00
Cody Robibero
2b10251b32
Update to dotnet6.rc2
2021-10-12 18:31:58 -06:00
Joe Rogers
e3eee10d05
Add image provider tests and clean up
2021-10-11 14:09:02 +02:00
Joe Rogers
8d70cc2dde
Add support for non-jpg image extractions
2021-10-11 14:09:02 +02:00
Joe Rogers
6ce8cce12c
Add handling for embedded background and logo
2021-10-11 14:09:01 +02:00
Joe Rogers
be9ed29f63
Split EmbeddedImage extracting to new provider
2021-10-11 14:09:01 +02:00
Claus Vium
1156699481
Merge pull request #6657 from Bond-009/dotnetbug
2021-10-09 12:19:44 +02:00
Claus Vium
b16e6621b3
Merge pull request #6663 from crobibero/dotnet-6-rc1
...
Reference dotnet6-rc1 packages
2021-10-08 16:06:15 +02:00
cvium
7abdf71c49
Revert to old line
2021-10-05 19:49:43 +02:00
cvium
229917a2f8
Queue refresh after subtitle upload + minor fixes
2021-10-04 21:12:09 +02:00
Cody Robibero
017380f1dd
Reference dotnet6-rc1 packages
2021-10-04 07:43:40 -06:00
Bond_009
9af16fcb6c
Remove workaround for dotnet/runtime#42790
2021-10-03 19:52:38 +02:00
KonH
b6bf43af45
Fix warning: Using directive is not required by the code and can be safely removed ( #2149 )
2021-10-03 10:49:41 +07:00
Cody Robibero
9234e5bf80
Remove all instances of en-US culture
2021-09-26 09:11:25 -06:00
Bond_009
f31224fa8f
Remove sync FileStream hack
2021-09-25 19:44:40 +02:00
Bond_009
13fbfe6091
Target net6.0
2021-09-24 20:15:46 +02:00
Bond-009
12a54c070e
Apply suggestions from code review
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-09-21 23:12:38 +02:00
Bond_009
8fec510971
ItemImageProvider: improve HTTP error handling
2021-09-21 22:47:30 +02:00
Claus Vium
f11f572997
Merge pull request #6457 from Izumiko/adult
2021-09-11 23:00:11 +02:00
Chris Tam
b0cd1f5e39
Fix images "not loading" after manual identification
2021-09-09 19:16:15 -04:00
Bond_009
0d16c48998
Fix some warnings
2021-09-09 15:59:13 +02:00
Fernando Fernández
3d0b1ccae6
Remove all unused usings
2021-09-06 21:15:30 +02:00
Claus Vium
74fef6c05b
Merge pull request #6177 from Bond-009/async
...
Use async FileStreams where it makes sense
2021-09-06 13:55:34 +02:00
Claus Vium
bf0a0c8b62
Merge pull request #6494 from Bond-009/cleanup
2021-09-06 13:55:16 +02:00
Cody Robibero
ec13412155
Merge remote-tracking branch 'upstream/master' into warn-259810
2021-09-03 06:56:45 -06:00
Bond_009
e3dac4fda2
Use async FileStreams where it makes sense
2021-09-02 14:02:04 +02:00