Bond_009
f46195899e
Improve perf of db save and query
2021-04-21 22:25:08 +02:00
Bond-009
24103d0953
Merge pull request #5876 from Bond-009/nullref5
...
DeepCopy: Throw ArgumentNullException if one of the args is null
2021-04-21 14:08:36 +02:00
Bond-009
48ed4b016c
Merge pull request #5808 from cvium/semi-fix-collection-perf
2021-04-21 13:52:51 +02:00
Bond_009
63e9b1ae2d
DeepCopy: Throw ArgumentNullException if one of the args is null
2021-04-20 22:59:51 +02:00
BaronGreenback
bc1cc2d04a
Remove unused using directives
2021-04-17 11:37:55 +01:00
BaronGreenback
bb6fddde9a
Group Methods
2021-04-17 11:19:09 +01:00
cvium
d44b2e2ee5
fixes
2021-04-13 20:12:50 +02:00
cvium
723b6abcb3
Optimize the way items are grouped into collections
2021-04-13 15:38:13 +02:00
Bond_009
a8ed753f6c
FxCop -> Net Analyzers (part 2)
2021-03-13 22:33:28 +01:00
cvium
c5a870051a
Use distinct for artists to avoid double refreshing
2021-03-10 08:20:02 +01:00
Bond_009
65bab55ca0
Minor improvements
2021-02-13 00:39:18 +01:00
crobibero
223b42aed3
Create BaseItemKind enum
2021-02-10 17:09:23 -07:00
Bond_009
a9b497720d
Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
...
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
| RoundTripBytes | 932.0 ns | 5.09 ns | 4.25 ns | 0.1173 | - | - | 368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 | - | - | 464 B |
```
2021-01-12 15:37:18 +01:00
David
043d045448
Put json serializer options in private field
2020-12-24 11:22:34 +01:00
David
b9dbdc7e54
Remove custom Json serializer from MediaBrowser.Controller
2020-12-23 13:25:49 +01:00
crobibero
ee23d06154
Use a more descriptive function name
2020-12-13 08:15:26 -07:00
crobibero
f5cce9e630
Use typed UserManager GetPreference
2020-12-11 15:04:14 -07:00
crobibero
b670937c3d
Use typed UserManager GetPreference
2020-12-11 15:00:43 -07:00
cvium
15a3d8d626
Forgot to revert some other changes, dunno if needed
2020-12-10 18:02:12 +01:00
Claus Vium
f1cc01f324
Merge pull request #4242 from Spacetech/library_scan_speed
...
Increase library scan and metadata refresh speed
2020-12-04 13:17:26 +01:00
Gary Wilber
f4edca7c27
Move MetadataRefreshThrottler to BaseItemManager
2020-12-02 18:51:53 -08:00
Joshua M. Boniface
a6199f821b
Merge pull request #4169 from stanionascu/bdiso-playback
...
Playback (direct-stream/transcode) of BDISO/BDAV containers
2020-12-01 22:36:04 -05:00
BaronGreenback
e8cb9cea7d
Merge branch 'master' into library_scan_speed
2020-11-21 22:54:40 +00:00
Joshua M. Boniface
bf54b5579c
Merge branch 'master' into defer_image_fetching
2020-11-21 17:20:31 -05:00
Joshua M. Boniface
7457c4a95d
Merge pull request #4499 from crobibero/more-param
...
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids
2020-11-20 12:34:18 -05:00
Gary Wilber
4a22380565
Merge remote-tracking branch 'upstream/master' into library_scan_speed
2020-11-19 18:44:16 -08:00
Joshua M. Boniface
212c5318ae
Merge pull request #4507 from BaronGreenback/Spelling
...
Corrects spelling in comments
2020-11-19 13:08:28 -05:00
Claus Vium
15b9f993c6
Merge pull request #4342 from crobibero/base-item-manager
...
Add BaseItemManager
2020-11-19 14:58:48 +01:00
Greenback
9a323f6df0
More spelling corrections.
2020-11-18 13:46:14 +00:00
crobibero
3cc0dd7e12
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage.
2020-11-16 20:29:46 -07:00
Kayila
d0cf60e145
Fixes #4465 by adding the missing extras folders.
2020-11-11 13:47:42 -05:00
Gary Wilber
e6d8c02944
Merge remote-tracking branch 'upstream/master' into library_scan_speed
2020-11-08 11:51:40 -08:00
cvium
584b4fa41f
Fix Persons, Genres and Studios endpoints
2020-11-05 12:27:22 +01:00
Anthony Lavado
6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
...
Minor improvements
2020-11-02 11:10:39 -05:00
Stan
3bb8884e16
Merge branch 'master' into bdiso-playback
2020-10-28 13:18:05 +01:00
crobibero
64b32d3290
Use BaseItemManager
2020-10-27 18:01:52 -06:00
Bond_009
5a9c218324
Fix build
2020-10-17 16:27:31 +02:00
Bond_009
49569ca0a0
Use nameof where possible
2020-10-17 16:19:57 +02:00
Jan-Pieter Baert
ec91d3893d
Fix SA 1116 warnings
2020-10-12 20:05:11 +02:00
cvium
763862cbd8
Defer image pre-fetching until the end of a refresh/scan
2020-10-03 13:36:53 +02:00
Gary Wilber
a51adec836
fix parallelism when set to 0
2020-10-02 18:26:10 -07:00
Gary Wilber
8f2fbf7a99
Switch to TPL dataflow for subfolder scan
2020-10-01 16:24:35 -07:00
Stanislav Ionascu
cd4641dca0
Remove PlayableStreamFileNames as unused
...
Since ffmpeg can play and transcode ISO files and BDMV folders directly,
there's no use of that property.
2020-10-01 22:20:34 +02:00
Gary Wilber
c2276b17cb
Increase library scan and metadata refresh speed
2020-09-30 19:33:34 -07:00
Matt Montgomery
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
2020-09-28 15:04:31 -05:00
Bond-009
5e76d5fd56
Merge pull request #3879 from cvium/fix_theme_songs
...
Populate ThemeVideoIds and ThemeSongIds
2020-09-04 13:13:39 +02:00
Claus Vium
abc527329d
Sort by SortName after scanning
2020-09-03 14:49:02 +02:00
Erwin de Haan
208b00fbb1
Add the item path to the ItemLookupInfo class.
...
This is important for the Shoko Anime Meatdata provider plugin.
2020-09-02 20:11:31 +02:00
Bond_009
c4d8275fc1
Fix duplicate
2020-08-23 00:26:32 +02:00
Bond_009
404bb4f835
Enable TreatWarningsAsErrors for MediaBrowser.Controller in Release
2020-08-22 21:56:24 +02:00
Bond_009
119f64f5e7
Make some methods async
2020-08-21 22:01:19 +02:00
Bond_009
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
2020-08-20 12:16:24 +02:00
Bond_009
68edccd9f4
More warn
2020-08-19 18:02:34 +02:00
Bond_009
2b400c99ef
Fix warnings
2020-08-19 17:50:50 +02:00
cvium
e10693cbe0
Remove some LINQ queries
2020-08-12 22:14:14 +02:00
cvium
1ae3dc202c
Populate ThemeVideoIds and ThemeSongIds
2020-08-11 22:04:41 +02:00
Bond-009
b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
...
Migrate Display Preferences to EF Core
2020-08-01 21:51:49 +02:00
Bond_009
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
2020-07-22 13:39:24 +02:00
Patrick Barron
ab396225ea
Migrate Display Preferences to EF Core
2020-07-17 16:11:53 -04:00
Patrick Barron
6d1b00da64
Use Array.Empty
2020-07-04 11:54:25 -04:00
crobibero
1398c2117c
Revert ILoggerFactory usage in BaseItem.cs
2020-06-23 07:31:59 -06:00
telans
6556bec646
brace multiline if statements (cont.)
2020-06-20 21:19:16 +12:00
telans
7f307f9082
brace multiline if statements
2020-06-20 21:12:36 +12:00
telans
98db8f72e0
fix SA1503 for one line if statements
2020-06-20 20:35:29 +12:00
telans
8de6452967
fix some documentation periods
2020-06-20 18:13:11 +12:00
telans
afe09612e8
fix SA1119
2020-06-20 18:13:11 +12:00
Bond-009
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans
247f9c61e6
fix SA1513/SA1516
2020-06-16 16:11:30 +12:00
telans
9018f8d8be
Add full stop at end of comments (SA1629)
2020-06-16 10:37:52 +12:00
telans
afc9224ede
fix SA1111
2020-06-15 10:46:43 +12:00
telans
3d9049ef08
fix SA1508
2020-06-15 10:45:55 +12:00
telans
acd4389653
fix SA1005
2020-06-15 10:41:00 +12:00
Patrick Barron
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
dkanada
403cd3205f
Merge pull request #3254 from crobibero/ilogger
...
Use typed logger where possible
2020-06-13 00:29:43 +09:00
Patrick Barron
fc02157b42
Fix build errors
2020-06-11 18:28:49 -04:00
Patrick Barron
7a115024aa
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# MediaBrowser.Controller/Library/ILibraryManager.cs
# MediaBrowser.Providers/Users/UserMetadataService.cs
2020-06-11 18:23:12 -04:00
aled
299e49f39d
Fix a small number of compile warnings
2020-06-09 23:12:53 +01:00
Bond-009
ad5c41b542
Merge pull request #3258 from aled/2149-fix-a-small-number-of-compile-warnings-1
...
Fix a small number of compile warnings
2020-06-09 22:22:36 +02:00
Patrick Barron
98142613e8
Apply review suggestions and fix bug
2020-06-07 13:36:43 -04:00
aled
22a860a806
Fix a small number of compile warnings
2020-06-06 20:17:49 +01:00
Daniyar Itegulov
613748b45d
Make books resumable and have duration of 1 second
2020-06-06 18:50:28 +10:00
crobibero
44957c5a9a
Use typed logger where possible
2020-06-05 18:15:56 -06:00
Patrick Barron
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00
Vasily
9208acd5ae
Convert non-local image to local before computing blurhash
2020-05-28 17:55:29 +03:00
Patrick Barron
31f725fdbf
Fix a bug in Emby.Notifications and clean up
2020-05-26 23:08:27 -04:00
Patrick Barron
eef7cfd912
Make SonarCloud less angry
2020-05-26 22:43:03 -04:00
Vasily
1f83a21288
Rename Hash to BlurHash in all properties and methods for clarity
2020-05-21 01:43:19 +03:00
Vasily
3fb4c1356c
Make blurhash be computed during regular scans if it was not already computed
2020-05-20 23:50:17 +03:00
Patrick Barron
c464f700db
Remove redundant qualifiers
2020-05-20 13:07:53 -04:00
Jesús Higueras
b9fc0d2628
Add BlurHash support to backend
2020-05-18 23:21:37 +03:00
Patrick Barron
9ad839c776
Initial migration code
2020-05-12 22:10:35 -04:00
Anthony Lavado
ed1dc5c922
Remove JsonIgnore from the DateLastSaved property of BaseItem
2020-04-20 02:35:47 -04:00
Bond_009
a73e1f18b6
Minor improvements
2020-04-19 11:16:09 +02:00
Mark Monteiro
64a255f090
Fix misformed xml doc comment
2020-04-10 15:02:54 -04:00
Vasily
5b59cd2eb2
Merge pull request #2696 from mark-monteiro/fix-extras
...
Display Extras With Unknown Types
2020-04-07 23:39:31 +03:00
Bond-009
0951dc632b
Update MediaBrowser.Controller/Entities/InternalPeopleQuery.cs
...
Co-Authored-By: Mark Monteiro <marknr.monteiro@protonmail.com>
2020-04-04 00:21:54 +02:00
Bond-009
d6224ddeda
Update InternalPeopleQuery.cs
2020-04-03 22:44:18 +02:00
Bond_009
3161e85f76
Address comments
2020-04-03 17:30:01 +02:00
Bond-009
f31efce52d
Merge branch 'master' into usings
2020-04-01 22:42:43 +02:00
Mark Monteiro
1a4d9d4c53
Code review suggestions
2020-04-01 19:41:52 +02:00
Bond_009
3ab50f5a3f
Address comments
2020-04-01 19:05:41 +02:00
Bond_009
787049f35f
Merge branch 'master' into minor
2020-04-01 18:53:22 +02:00
Mark Monteiro
cc8294842a
Add ExtraType.Unknown enum value and use it instead of null
2020-04-01 18:10:29 +02:00
Mark Monteiro
e266ad51c5
Simplify logic; remove unnecessary methods
2020-03-28 14:17:33 +01:00
Mark Monteiro
ea306e8f6d
Do not assign an invalid value of zero to ExtraType
2020-03-28 13:54:14 +01:00
Mark Monteiro
5fcbedc194
Display extras with an unknown type
2020-03-28 13:40:56 +01:00
Bond_009
e9d1eabd53
Remove unused usings
2020-03-24 16:12:06 +01:00
Mark Monteiro
6897a19051
Add missing null check when retrieving extras
2020-03-22 15:09:51 +01:00
dkanada
a96c0a72b8
Merge pull request #2549 from dkanada/refactor
...
Refactor some provider classes
2020-03-18 17:43:15 +09:00
Bond-009
008a76cf4d
Merge pull request #2502 from JustAMan/baseitem-equals
...
Adds BaseItem.Equals method that compares items by their Id
2020-03-11 16:00:36 +01:00
dkanada
52fde64f10
remove unused files and fix some future warnings
2020-03-09 23:30:57 +09:00
Vasily
f4ccee5801
Add inheritdoc comment and squash simple method bodies
2020-03-05 15:03:17 +03:00
Vasily
456f571343
Follow code review suggestions
2020-03-05 14:25:50 +03:00
Vasily
007c5b9f67
Implement BaseItem.GetHashCode override
2020-03-04 13:06:13 +03:00
dkanada
c07e1e4f84
Merge pull request #2476 from JustAMan/playto-sort
...
Bring back sorting when needed to fix PlayTo
2020-03-04 01:53:26 +09:00
Vasily
f21cd30039
Lower log level for BaseItem.Equals to debug
2020-03-03 19:22:45 +03:00
Bond-009
1c21248e2e
Merge pull request #2474 from JustAMan/simplify-sorting
...
Simplify AlphanumericComparer, reduce code duplication
2020-03-02 12:28:31 +01:00
Vasily
ba8d8cede9
Replace foreach with for - MOAR SPEED
2020-03-02 12:39:34 +03:00
Vasily
9a9f2aa293
Apply suggestions from code review
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-03-02 12:36:44 +03:00
Vasily
11abe31e0d
Speed up equality comparison of BaseItem
2020-03-02 12:31:31 +03:00
Vasily
7f38af3701
Remove custom queue class as it is not needed
2020-02-28 17:27:16 +03:00
Vasily
f81cd037f0
Small speed improvement - no need to convert an array to a list to just iterate over it
2020-02-28 16:19:51 +03:00
Vasily
ae1f975b99
Implement fast sorting
2020-02-27 20:21:34 +03:00
Vasily
0f0b89f344
Trying to be more safe
2020-02-27 20:14:56 +03:00
Vasily
e125db4fe3
Bring back sorting when needed to fix PlayTo
...
This is partial revert of https://github.com/jellyfin/jellyfin/pull/1011
2020-02-27 20:11:40 +03:00
Vasily
d1670f8180
Apply suggestions from code review
...
Co-Authored-By: Claus Vium <cvium@users.noreply.github.com>
2020-02-27 16:02:18 +03:00
Vasily
8e20d2e931
Simplify AlphanumericComparer, reduce code duplication
2020-02-27 14:51:34 +03:00
Bond_009
a07ee65365
Minor improvements
2020-02-23 10:53:51 +01:00
dkanada
65a9d618cc
add config options for musicbrainz
2020-02-22 15:04:52 +09:00
Bond-009
b02a3a29f5
Fix photo serialization
2020-02-20 15:30:04 +01:00
Bond-009
6a6472bb8a
Update MediaBrowser.Controller/Entities/PersonInfo.cs
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2020-02-04 12:28:16 +01:00
Bond-009
c9e11c95ee
Apply suggestions from code review
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2020-02-04 12:05:14 +01:00
Bond_009
32dcd372f4
Fix some warnings in MediaBrowser.Controller
2020-02-04 02:10:44 +01:00
Bond_009
87d2479b78
Fix warnings
2020-01-31 22:26:53 +01:00
Carey Metcalfe
d3de91dab6
Fix another issue with DLNA responses not properly paginating
...
The `UserRootFolder.GetItemsInternal` method now applies any sorting and
pagination requested by the `InternalItemsQuery` that was passed to it.
Previous pagination fix : #2304
Original issue #2303
2020-01-24 00:43:28 -05:00
Bond_009
bb236b9591
Merge branch 'master' into warn12
2020-01-10 21:18:16 +01:00
dkanada
aca31457c0
merge branch master into media-attachments
2020-01-08 01:21:09 +09:00
Bond_009
7f5a174dff
Merge branch 'master' into warn12
2019-12-20 19:43:57 +01:00
Bond_009
2ef4ffd698
More warnings (removed)
2019-12-11 00:13:57 +01:00
Bond_009
0bf8bfbb0c
Merge branch 'master' into mediaencoding
2019-12-10 23:00:59 +01:00
Bond-009
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
2019-12-06 12:06:13 +01:00
Bond_009
cc5acf37f7
Make probesize and analyzeduration configurable and simplify circular
...
dependencies
Makes the probesize and analyzeduration configurable with env args.
(`JELLYFIN_FFmpeg_probesize` and `FFmpeg_analyzeduration`)
2019-11-25 12:07:59 +01:00
dkanada
51cdc6ea16
Merge pull request #1926 from Bond-009/auth
...
Add clearer exceptions, warnings and docs
2019-11-23 01:14:32 +09:00
dkanada
f51f59d675
Merge pull request #1965 from Bond-009/dbjson
...
Deserialize with the correct type (and warning fixes)
2019-11-10 16:51:54 +09:00
Andrew Mahone
1600d5b53f
Merge remote-tracking branch 'origin/master' into media-attachments-clean
2019-11-04 10:03:18 -05:00
Bond_009
846857b60e
Deserialize with the correct type (and warning fixes)
2019-11-01 17:07:42 +01:00
Bond_009
d9a03c9bb1
Fix more warnings
2019-10-29 17:55:16 +01:00
Andrew Mahone
f22ca6dd9e
Retrieve media attachments in BaseItem.
2019-10-22 10:36:54 -04:00
Bond_009
fef35d0505
Add clearer exceptions, warnings and docs
2019-10-20 21:12:03 +02:00
Bond_009
bbc0875387
Don't shuffle some types by default
2019-10-20 16:08:40 +02:00
