lgladsden/jellyfin-server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
20,474 Commits 2 Branches 0 Tags 64 MiB
8933389753
Commit Graph

540 Commits

Author SHA1 Message Date
cvium
8933389753 Respect user settings for transcode and remux 2021-04-19 10:49:52 +02:00
Stephen Moore
e841922ffd Fix ArgumentOutOfRangeException scanning AudioBooks 
AudioResolver.ResolveMultipleAudio method can attempt to access the first item in a List without checking if the list is empty which throws an ArgumentOutOfRangeException and stops the 'Scan Library' process.
 2021-04-17 17:21:40 +01:00
BaronGreenback
bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
Bond_009
8045a488ce Fix possible ArgumentNullException 
```
  Error Message:
   System.ArgumentNullException : Value cannot be null. (Parameter 'source')
  Stack Trace:
     at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.Select[TSource,TResult](IEnumerable`1 source, Func`2 selector)
   at Emby.Server.Implementations.Library.LibraryManager.ResolveItem(ItemResolveArgs args, IItemResolver[] resolvers) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 475
   at Emby.Server.Implementations.Library.LibraryManager.ResolvePath(FileSystemMetadata fileInfo, IDirectoryService directoryService, IItemResolver[] resolvers, Folder parent, String collectionType, LibraryOptions libraryOptions) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 618
   at Emby.Server.Implementations.Library.LibraryManager.ResolvePath(FileSystemMetadata fileInfo, Folder parent) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 536
   at Emby.Server.Implementations.Library.LibraryManager.GetUserRootFolder() in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 812
   at Emby.Server.Implementations.Library.LibraryManager.GetCollectionFolders(BaseItem item) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 2080
   at Emby.Server.Implementations.Library.LibraryManager.GetLibraryOptions(BaseItem item) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 2116
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType, IEnumerable`1 savers) in /home/vsts/work/1/s/MediaBrowser.Providers/Manager/ProviderManager.cs:line 672
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType) in /home/vsts/work/1/s/MediaBrowser.Providers/Manager/ProviderManager.cs:line 655
   at Emby.Server.Implementations.Library.LibraryManager.RunMetadataSavers(BaseItem item, ItemUpdateType updateReason) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 2017
   at Emby.Server.Implementations.Library.LibraryManager.UpdateItemsAsync(IReadOnlyList`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 1975
   at Emby.Server.Implementations.Library.LibraryManager.CreateRootFolder() in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 775
   at Emby.Server.Implementations.Library.LibraryManager.get_RootFolder() in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 180
   at Emby.Server.Implementations.IO.LibraryMonitor.Start() in /home/vsts/work/1/s/Emby.Server.Implementations/IO/LibraryMonitor.cs:line 135
   at Emby.Server.Implementations.IO.LibraryMonitorStartup.RunAsync() in /home/vsts/work/1/s/Emby.Server.Implementations/IO/LibraryMonitorStartup.cs:line 26
   at Emby.Server.Implementations.ApplicationHost.StartEntryPoints(IEnumerable`1 entryPoints, Boolean isBeforeStartup)+MoveNext() in /home/vsts/work/1/s/Emby.Server.Implementations/ApplicationHost.cs:line 518
   at System.Threading.Tasks.Task.WhenAll(IEnumerable`1 tasks)
   at Emby.Server.Implementations.ApplicationHost.RunStartupTasksAsync(CancellationToken cancellationToken) in /home/vsts/work/1/s/Emby.Server.Implementations/ApplicationHost.cs:line 502
   at Jellyfin.Server.Integration.Tests.JellyfinApplicationFactory.CreateServer(IWebHostBuilder builder) in /home/vsts/work/1/s/tests/Jellyfin.Server.Integration.Tests/JellyfinApplicationFactory.cs:line 101
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.EnsureServer()
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(Uri baseAddress, DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient()
   at Jellyfin.Server.Integration.Tests.Controllers.ActivityLogControllerTests.ActivityLog_GetEntries_Ok() in /home/vsts/work/1/s/tests/Jellyfin.Server.Integration.Tests/Controllers/ActivityLogControllerTests.cs:line 21
--- End of stack trace from previous location ---
```
 2021-04-12 22:01:35 +02:00
Joshua M. Boniface
cd0daa7985
Merge pull request #5748 from cvium/playlist-audio-type 
Set mediatype to Audio for playlists in a music library
 2021-04-11 13:28:49 -04:00
cvium
ef527df28f Set mediatype to Audio for playlists in a music library 2021-04-10 00:06:48 +02:00
cvium
f2cba352e5 catch ioexception and include stack trace 2021-04-09 23:30:07 +02:00
Claus Vium
a21b2714e7
fetching images should not kill the scanner 2021-04-09 12:03:56 +02:00
Bond-009
a0258618ac
Update Emby.Server.Implementations/Library/Resolvers/TV/SeriesResolver.cs 
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
 2021-04-01 21:24:34 +02:00
Bond_009
aa76957338 Remove useless code 2021-04-01 19:16:00 +02:00
Bond-009
b49d50e634
Merge pull request #5467 from Ullmie02/nfo-fixes 2021-03-30 15:35:56 +02:00
David
78f7fdeacc Rename methods and optimize allocations 2021-03-26 17:16:29 +01:00
Bond-009
066c19a26b
Fix possible null ref exception 2021-03-24 21:06:03 +01:00
David
14cbd22fbe Use Helper Methods for provider url parsing 2021-03-16 21:45:12 +01:00
cvium
025e351f61 add unit tests 2021-03-15 08:25:20 +01:00
cvium
ab0cff8556 do not resolve episode-like files if they are in extras folders 2021-03-14 19:56:45 +01:00
Bond_009
a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
Bond_009
5241bd41ef Add code analysis attributes where appropriate 2021-03-09 01:28:21 +01:00
Joshua M. Boniface
82d88bdec6
Merge pull request #5409 from ikomhoog/master 2021-03-08 16:39:40 -05:00
Claus Vium
90cdd1345d
Merge pull request #5407 from Bond-009/hack 2021-03-08 21:23:14 +01:00
Bond_009
54f81c4da4 Call ToLower on CollectionTypeOptions.ToString 2021-03-08 12:08:17 +01:00
Ikomhoog
d4201f812c Changed string.Length == 0 to string.IsNullOrEmpty in case of null 2021-03-08 11:02:51 +01:00
cvium
946411be8e Remove redundant check 2021-03-06 21:18:20 +01:00
cvium
67af30d1ff Remove redundant checks 2021-03-06 20:53:50 +01:00
cvium
54211b921c rider is a prick 2021-03-06 19:07:02 +01:00
cvium
bc661c16e1 simplify 2021-03-06 14:01:37 +01:00
cvium
37e374d33d make sure network path substitution matches correctly 2021-03-05 14:09:23 +01:00
Bond_009
81f527f808 CollectionType can be null 2021-02-24 11:57:04 +01:00
Bond_009
1c74e2f40e Fix build 2021-02-24 02:57:10 +01:00
Bond_009
914e891689 Fix unchecked input 2021-02-24 02:05:12 +01:00
dkanada
9fcdbd4c4b remove deprecated settings from server config 2021-02-12 21:58:37 +09:00
Bond_009
a9b497720d Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip 
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.

```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
  [Host]     : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
  DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT

|          Method |       Mean |    Error |   StdDev |  Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
|  RoundTripBytes |   932.0 ns |  5.09 ns |  4.25 ns | 0.1173 |     - |     - |     368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 |     - |     - |     464 B |
```
 2021-01-12 15:37:18 +01:00
Bond-009
4549c96f6d
Merge pull request #4906 from Spacetech/library_scan_ignore_inaccessible 
Ignore inaccessible files & folders during library scans
 2021-01-08 21:01:32 +01:00
Ian
0f4bbbc63c Fix 3169 and 2879 by making MusicArtistResolver run ahead of MusicAlbumResolver 2021-01-06 10:58:07 -08:00
Gary Wilber
1fdeac0a7d Ignore inaccessible files during library scans 2020-12-31 18:40:24 -08:00
Joshua M. Boniface
7caba04c3c
Merge pull request #4890 from nielsvanvelzen/4888-fix-search-hints 
Fix search hint endpoint error
 2020-12-30 19:55:57 -05:00
artiume
f411353c8c
Update Emby.Server.Implementations/Library/UserDataManager.cs 
Co-authored-by: Bond-009 <bond.009@outlook.com>
 2020-12-30 09:30:02 -05:00
artiume
c7cb177260
Update Emby.Server.Implementations/Library/UserDataManager.cs 
Co-authored-by: Bond-009 <bond.009@outlook.com>
 2020-12-30 09:12:36 -05:00
artiume
77b478c726
Update Emby.Server.Implementations/Library/UserDataManager.cs 
Co-authored-by: Bond-009 <bond.009@outlook.com>
 2020-12-30 09:12:13 -05:00
artiume
99adbf0497
Split resume function for Audiobooks 2020-12-30 08:48:33 -05:00
Niels van Velzen
2bb84c0675 Fix limit parameter error for search hints endpoint 2020-12-30 11:16:09 +01:00
David
043d045448 Put json serializer options in private field 2020-12-24 11:22:34 +01:00
David
a714008b59 Add missing FileStreams 2020-12-23 21:00:50 +01:00
David
2a574914ea Use streams instead of strings 2020-12-23 19:24:58 +01:00
David
196388d607 Remove custom Json serializer from Emby.Server.Implementations 2020-12-23 13:14:40 +01:00
Claus Vium
21d2e9ff0c
Merge pull request #4771 from crobibero/typed-get-preference 
Use typed UserManager GetPreference
 2020-12-16 22:15:56 +01:00
crobibero
ee23d06154 Use a more descriptive function name 2020-12-13 08:15:26 -07:00
artiume
297cb27ab6
remove opf extension for book types 2020-12-11 21:13:28 -05:00
crobibero
b670937c3d Use typed UserManager GetPreference 2020-12-11 15:00:43 -07:00
cvium
3f6e6c4839 Simplify 2020-12-10 14:47:47 +01:00