Commit Graph

23 Commits

Author SHA1 Message Date
senritsu
4e21b49994 adjust episode path expression to allow digits in series names
The previous expression was too greedy to consume digits, because the hyphen was optional. This lead to incorrect episode numbers for certain series with digits in their names, in those cases each episode was recognized as the same episode number (the digit from the series name).

The rule, which matches most standard  anime filenames, also had a lower priority than one of the Kodi rules, leading to incorrect recognition for absolute numbered episodes with triple digits and higher (first digit was used as season number, rest of digits as episode number). This also resolves one of the TODO test cases.

Additional test cases were added to ensure that both hyphens in different parts of the filename, as well as names without hyphens, still work correctly. All previous test cases still pass.

Unfortunately another TODO (EpisodeNumberTests.cs@L76, Uchuu Senkan Yamato 2199) with the same issue (digits in the series name) could not be trivially fixed in the same change, due to the significantly different formatting. Attempts to resolve this case did not work out for now.
2021-01-17 20:24:23 +01:00
Stepan
195a6261c4 Dummy test case explanation. 2020-11-10 19:28:03 +01:00
Stepan
3d1076ae42 Rest of tests for Emby.Naming code coverage 2020-11-07 12:30:22 +01:00
Stepan
f22e0800e2 Episode parsing coverage 2020-11-07 11:02:12 +01:00
Stepan
60b49e67ea Re-Sharper inspection issues 2020-11-01 11:19:22 +01:00
aled
3ff6e3ff65 Add code analyzers to Jellyfin.Naming.Tests and fix resulting warnings 2020-05-14 18:59:10 +01:00
aled
2849d2b134 Fix compile warnings in Jellyfin.Naming.Tests 2020-05-13 23:59:19 +01:00
Narfinger
107974e3f8 moves shows tests to Theory and InlineData format 2020-02-27 11:35:01 +09:00
dkanada
fd3ee279de
Merge pull request #2448 from Narfinger/tests-fix2
adds names from the episodenumber tests to path tests
2020-02-27 02:05:16 +09:00
Narfinger
496bdc65f3 adds names from the episodenumber tests to path tests 2020-02-23 19:45:29 +09:00
Narfinger
fd5f0c54a6 fixes formatting and enabling another test 2020-02-23 18:50:33 +09:00
Narfinger
b306b8b881 add todos and fixes some todo tests 2020-02-23 18:46:10 +09:00
Narfinger
4dabc50f09 fixes last tests and cleanup 2020-02-23 18:31:23 +09:00
Narfinger
c2fe628c79 removed failing tests 2020-02-23 18:19:19 +09:00
Narfinger
21f11c600a converted tests to inlinedata 2020-02-23 12:12:48 +09:00
Bond-009
7df6d4e7a0
Update EpisodeNumberTests.cs 2020-02-20 12:02:45 +01:00
Bond_009
dfd74adc15 Add test 2020-02-19 22:51:30 +01:00
Bond_009
620047ab9a Fix episode parsing 2020-02-19 22:35:40 +01:00
Bond_009
dc62e436c4 Clean up Emby.Naming 2020-01-22 22:18:56 +01:00
dkanada
11c758b6be remove unsupported test cases 2020-01-21 00:20:24 +09:00
dkanada
e700fc8a07 fix and remove a few more tests 2020-01-19 00:18:55 +09:00
Bond-009
8723bdbb4f Fix tests 2019-12-18 11:52:32 +01:00
Bond_009
35151553e3 Add back all old emby tests 2019-12-06 20:41:39 +01:00