Commit Graph

21 Commits

Author SHA1 Message Date
Szymon Acedański
b1e8a8565f
Update Jellyfin.Api/Helpers/FileStreamResponseHelpers.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-24 22:46:08 +01:00
Szymon Acedański
136136dea9 Fix incorrect responses for HEAD /audio/<id>/stream
Without this fix my Samsung Soundbar (HW-Q80R) fails to play using DLNA
and returns "Error: Resource not found (716)" instead.

I had a look on tcpdump network logs between Jellyfin and the soundbar
and noticed that the device performs a HEAD request for the media before
responding to the DLNA UPNP control request from Jellyfin (or BubbleUPNP
Android App).

Jellyfin retuns 204 No Content response, which is unusual.  Common web
servers generally return 200 OK if the GET would return content, and
this is not-very-clearly suggested [in HTTP
spec](https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.1)

The other patch is to ensure, that invalid Content-Length: 0 is not
returned with the HEAD response in the streaming case.

I think in both cases we still don't return the same headers with HEAD
as with GET (e.g. Content-Length or Accept-Ranges), but at least we
don't return anything misleading.
2021-03-24 20:43:54 +01:00
BaronGreenback
d819a1d928
Remove Content-Length header from DLNA HEAD request (#5335) 2021-03-03 15:41:18 +01:00
Bond_009
e9f22303a4 Properly forward cancellationTokens 2021-02-15 14:19:17 +01:00
Bond_009
4b1c9dc9ea Pass cancellation where possible 2020-11-17 19:43:00 +01:00
crobibero
01355e0498 Fix nullability errors in Jellyfin.Api (part 1) 2020-11-13 09:04:31 -07:00
cvium
6ca313abc1 Add ProgressiveFileStream 2020-09-25 23:59:17 +02:00
BaronGreenback
25e965b85c
Update FileStreamResponseHelpers.cs 2020-09-05 20:33:18 +01:00
BaronGreenback
d3e8834e80
Removed memoryStream 2020-09-05 20:03:21 +01:00
David
4836f14aff Enable HTTP Range Processing 2020-09-05 10:38:16 +02:00
Anthony Lavado
634ee2d1e9
Merge pull request #3861 from crobibero/fixes
API Fixes
2020-08-19 08:17:03 -04:00
crobibero
be67528958 add disposal docs 2020-08-17 15:03:45 -06:00
crobibero
767c73e5c1 fix usings 2020-08-17 13:22:42 -06:00
crobibero
c5e9cf15f6 Use proper IHttpContextAccessor 2020-08-10 07:53:32 -06:00
crobibero
f543a17d1b Apply review fixes 2020-07-30 06:29:06 -06:00
crobibero
b8d327889b Add missing functions 2020-07-27 13:42:40 -06:00
David
ca3dcc3db0 Fix suggestions from review 2020-07-24 19:14:53 +02:00
David
d39f481a5c Apply suggestions from review 2020-07-23 12:46:54 +02:00
David
2ce97c022e Move AudioService to Jellyfin.Api 2020-07-22 16:57:06 +02:00
David
07e56850be Remove caching and content length 2020-07-22 10:39:48 +02:00
David
3514813eb4 Continute work 2020-07-19 19:03:48 +02:00