Commit Graph

129 Commits

Author SHA1 Message Date
Bond_009
a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Bond_009
19824bff94 Minor improvements 2021-08-15 23:48:19 +02:00
Bond-009
a4a3f598af
Merge pull request #5982 from Bond-009/nullable 2021-05-06 23:33:41 +02:00
BaronGreenback
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? (#5845)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:51:14 +02:00
Bond_009
91c2a57b28 Enable nullable reference types for MediaBrowser.Common 2021-05-05 12:57:01 +02:00
BaronGreenback
65f880be32 Keep plugin status after update. 2021-04-06 20:59:47 +01:00
Bond_009
a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
Bond_009
a6d0db5d04 100% branch coverage for DashboardController 2021-03-05 11:15:14 +01:00
dkanada
64cc5889f2 add suggested changes 2021-02-23 23:11:17 +09:00
dkanada
bc746b4d05 merge branch 'master' into auto-manifest 2021-02-23 19:19:38 +09:00
Bond_009
57102090d3 Add tests for DashboardController 2021-02-22 13:15:29 +01:00
dkanada
9caf311925 handle plugin manifests automatically 2021-02-12 22:33:10 +09:00
BaronGreenback
62702fa3eb Changes as requested 2020-12-23 16:28:50 +00:00
BaronGreenback
621e6d28cd Fallback to default guid 2020-12-22 14:07:01 +00:00
BaronGreenback
3633996a53 New json converter implemented. 2020-12-21 09:01:59 +00:00
BaronGreenback
53e280b80f json name override. 2020-12-20 16:29:28 +00:00
BaronGreenback
46c7499e2b reverted change 2020-12-18 23:55:23 +00:00
BaronGreenback
bae8f0c4ec corrected. 2020-12-18 23:52:19 +00:00
Greenback
5c4fdaa253 MaxAbi property removed. 2020-12-18 21:05:27 +00:00
Greenback
5d748c0e9f Renamed to ImagePath 2020-12-18 20:52:44 +00:00
Greenback
ce19f2be55 Renamed Guid property to Id 2020-12-18 20:37:35 +00:00
Greenback
486148dd6b Removed maxAbi 2020-12-18 09:44:57 +00:00
Greenback
5a3efc5266 Changes as required. 2020-12-18 09:04:40 +00:00
BaronGreenback
212c76102d
Update PluginManifest.cs 2020-12-17 13:37:13 +00:00
Greenback
d9aaba36ec Copy previous plugin settings if they don't exist. 2020-12-16 23:19:09 +00:00
Greenback
6d3e1d6b57 Small Optimization 2020-12-16 19:37:23 +00:00
Greenback
5323887540 Replaced TryGetPlugin with GetPlugin 2020-12-15 20:27:42 +00:00
Greenback
eb2439f23b Changes as recommended. 2020-12-15 16:37:11 +00:00
Greenback
fbb20ebef6 Plugin setting migration to folders. 2020-12-15 00:42:59 +00:00
Greenback
7986465cf7 Initial upload 2020-12-14 16:14:39 +00:00
BaronGreenback
cab78f40b3
[Fix] Possible null reference. (#4585)
Fix possible null reference.
2020-11-28 15:44:14 +01:00
BaronGreenback
47f3bb33f9
Update BasePlugin.cs 2020-11-20 09:03:11 +00:00
BaronGreenback
9c3e484c0e
Update BasePlugin.cs 2020-11-19 18:14:38 +00:00
BaronGreenback
ef05485243
Merge branch 'master' into PluginConfigSave 2020-11-19 09:04:49 +00:00
BaronGreenback
3ffdcfdb80
Update BasePlugin.cs 2020-11-19 09:03:03 +00:00
crobibero
d608ab8042 Fix null reference when saving plugin configuration 2020-11-18 09:29:18 -07:00
Bond-009
331c7f8481
Merge pull request #4253 from BaronGreenback/fordiscussion
DI in plugins
2020-11-15 13:29:04 +01:00
BaronGreenback
51996cd34d
Update BasePlugin.cs 2020-11-11 19:04:22 +00:00
BaronGreenback
957b5df0f0
Update MediaBrowser.Common/Plugins/IPluginServiceRegistrator.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-11-09 11:26:06 +00:00
BaronGreenback
429de72443
Update MediaBrowser.Common/Plugins/BasePlugin.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-11-09 11:25:42 +00:00
crobibero
73f923c8d5 Use class instead of struct 2020-11-08 09:31:53 -07:00
BaronGreenback
38da2ee26e
Merge branch 'master' into update-plugin 2020-10-17 09:47:20 +01:00
BaronGreenback
be4e5eff9c
Update BasePlugin.cs 2020-10-16 14:58:37 +01:00
BaronGreenback
257acbc2c9
Update BasePlugin.cs 2020-10-12 20:33:08 +01:00
BaronGreenback
53bea919d0
Update IPluginServiceRegistrator.cs 2020-10-12 07:51:09 +01:00
BaronGreenback
f7cc2f785c
Rename IPluginRegistrar.cs to IPluginServiceRegistrator.cs 2020-10-12 07:48:53 +01:00
BaronGreenback
ae8a3bc02c
Update MediaBrowser.Common/Plugins/IPluginRegistrar.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-10-11 23:49:34 +01:00
Cody Robibero
ee976bb47a
Update MediaBrowser.Common/Plugins/LocalPlugin.cs
Co-authored-by: BaronGreenback <jimcartlidge@yahoo.co.uk>
2020-10-11 15:27:11 -06:00
BaronGreenback
d31178ab4b
Update BasePlugin.cs 2020-10-11 20:00:46 +01:00
BaronGreenback
7e939fa2cb
Update BasePlugin.cs
Plugins supporting di cannot be unloaded.
2020-10-11 19:56:05 +01:00