Commit Graph

157 Commits

Author SHA1 Message Date
Bond_009
a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Bond_009
f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Cody Robibero
7bfc6b5679 Remove more warnings 2021-12-27 07:38:06 -07:00
cvium
b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
Bond_009
a4565da4a9 Use System.IO.Compression instead of SharpCompress for zips
Also removes unused methods from ZipClient
2021-12-18 17:52:38 +01:00
Bond_009
1d19a5be61 Fix some warnings
down to 580
2021-11-09 22:29:33 +01:00
Patrick Barron
7ea4c844c8 Fix warnings in InstallationManager 2021-10-03 21:41:22 -04:00
Bond_009
6f8ccab788 Move non-jellyfin extensions to separate project 2021-06-19 18:04:46 +02:00
Bond_009
383c2d7374 Remove useless nullable directives 2021-06-11 23:36:10 +02:00
Bond_009
c78457e6d3 Minor fixes 2021-06-06 18:11:51 +02:00
Bond_009
7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
BaronGreenback
b645bb20de
Update Emby.Server.Implementations/Updates/InstallationManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-04-08 14:38:25 +01:00
BaronGreenback
65f880be32 Keep plugin status after update. 2021-04-06 20:59:47 +01:00
Bond_009
a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
dkanada
64cc5889f2 add suggested changes 2021-02-23 23:11:17 +09:00
dkanada
9caf311925 handle plugin manifests automatically 2021-02-12 22:33:10 +09:00
BaronGreenback
8e04e6c837
Update Emby.Server.Implementations/Updates/InstallationManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-12-23 10:27:27 +00:00
BaronGreenback
63c290f878
Update Emby.Server.Implementations/Updates/InstallationManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-12-23 10:26:20 +00:00
BaronGreenback
4757824a82
Update Emby.Server.Implementations/Updates/InstallationManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-12-18 21:55:50 +00:00
Greenback
cb793af30e Renamed guid to id 2020-12-18 21:11:29 +00:00
Greenback
5c4fdaa253 MaxAbi property removed. 2020-12-18 21:05:27 +00:00
Greenback
ce19f2be55 Renamed Guid property to Id 2020-12-18 20:37:35 +00:00
Greenback
486148dd6b Removed maxAbi 2020-12-18 09:44:57 +00:00
Greenback
1ed25ebd9a Corrections as recommended. 2020-12-16 22:36:25 +00:00
Greenback
5323887540 Replaced TryGetPlugin with GetPlugin 2020-12-15 20:27:42 +00:00
Greenback
eb2439f23b Changes as recommended. 2020-12-15 16:37:11 +00:00
Greenback
208d545cfe Changed as suggested. 2020-12-15 10:05:04 +00:00
Greenback
cddc87e2af Fixed gitmerge. 2020-12-15 01:23:52 +00:00
BaronGreenback
67c480ad53
Merge branch 'master' into PluginDowngrade 2020-12-15 01:15:54 +00:00
Greenback
0d4aa6bad6 Enable local file repositories 2020-12-15 01:13:11 +00:00
Greenback
7986465cf7 Initial upload 2020-12-14 16:14:39 +00:00
Claus Vium
f322866127
Merge pull request #4737 from crobibero/missing-ensure-success 2020-12-11 09:53:43 +01:00
crobibero
e621244405 Add missing EnsureSuccessStatusCode 2020-12-08 08:28:19 -07:00
crobibero
8df2213d6b Don't return plugin versions that target newer Jellyfin version 2020-12-06 10:13:08 -07:00
Bond_009
8c8a71692e Remove Hex class as the BCL has one now 2020-11-25 23:40:31 +01:00
crobibero
c5f5633ec6 Handle invalid plugins 2020-11-22 12:35:45 -07:00
Greenback
1df58fbaa0 updated 2020-11-19 14:12:33 +00:00
Greenback
18855a7884 Initialial upload 2020-11-19 13:34:09 +00:00
Bond_009
4b1c9dc9ea Pass cancellation where possible 2020-11-17 19:43:00 +01:00
crobibero
95a2de757f remove custom HttpException 2020-11-14 14:30:34 -07:00
Claus Vium
3900976be5
Merge pull request #4247 from crobibero/update-plugin
Update all on-disk plugins
2020-11-08 18:00:49 +01:00
Anthony Lavado
b1b43b8ad9
Merge pull request #4068 from barronpm/event-fixes
Fix Plugin Events and Clean Up InstallationManager.cs
2020-11-02 11:11:17 -05:00
crobibero
53d8023def Update all on-disk plugins 2020-09-30 17:37:30 -06:00
Bond-009
cbf9be9416
Merge pull request #3577 from crobibero/package-install-repo
Specify plugin repo on plugin installation
2020-09-29 18:24:11 +02:00
Matt Montgomery
53d5f64e03 Fix SA1513, SA1514, SA1507, and SA1508 2020-09-28 15:04:31 -05:00
crobibero
b7022e8dc1 Merge remote-tracking branch 'upstream/master' into package-install-repo 2020-09-26 16:57:53 -06:00
Joshua M. Boniface
bc5404cd6f
Merge pull request #3401 from BaronGreenback/Plugins
Fix for windows plug-in upgrades issue: #1623
2020-09-16 17:22:58 -04:00
BaronGreenback
ddfb13f945
Update Emby.Server.Implementations/Updates/InstallationManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-09-08 17:50:37 +01:00
BaronGreenback
f4eb34a966
Update Emby.Server.Implementations/Updates/InstallationManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-09-08 17:50:19 +01:00
Anthony Lavado
cc6b03296a
Merge pull request #3899 from crobibero/plugin-install
Install specific plugin version if requested
2020-09-07 19:39:55 -04:00