Commit Graph

20571 Commits

Author SHA1 Message Date
Bond-009
8eaefce14e
Merge pull request #5691 from Bond-009/nullref3
Fix possible nullref
2021-04-04 13:22:49 +02:00
Bond_009
2ed0801be2 Fix possible nullref
when `ProviderManager.SaveMetadata` gets called before
`ProviderManager.AddParts`

```
Error Message:
   System.ArgumentNullException : Value cannot be null. (Parameter 'source')
  Stack Trace:
     at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType, IEnumerable`1 savers) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 674
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 655
   at Emby.Server.Implementations.Library.LibraryManager.RunMetadataSavers(BaseItem item, ItemUpdateType updateReason) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 2012
   at Emby.Server.Implementations.Library.LibraryManager.UpdateItemsAsync(IReadOnlyList`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 1970
   at Emby.Server.Implementations.Library.LibraryManager.CreateRootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 775
   at Emby.Server.Implementations.Library.LibraryManager.get_RootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 180
   at Emby.Server.Implementations.IO.LibraryMonitor.Start() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitor.cs:line 135
   at Emby.Server.Implementations.IO.LibraryMonitorStartup.RunAsync() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitorStartup.cs:line 26
   at Emby.Server.Implementations.ApplicationHost.StartEntryPoints(IEnumerable`1 entryPoints, Boolean isBeforeStartup)+MoveNext() in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 541
   at System.Threading.Tasks.Task.WhenAll(IEnumerable`1 tasks)
   at Emby.Server.Implementations.ApplicationHost.RunStartupTasksAsync(CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 525
   at Jellyfin.Server.Integration.Tests.JellyfinApplicationFactory.CreateServer(IWebHostBuilder builder) in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\JellyfinApplicationFactory.cs:line 101
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.EnsureServer()
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(Uri baseAddress, DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient()
   at Jellyfin.Server.Integration.Tests.OpenApiSpecTests.GetSpec_ReturnsCorrectResponse() in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\OpenApiSpecTests.cs:line 26
--- End of stack trace from previous location ---
```
2021-04-04 01:45:15 +02:00
Bond-009
fa64d8e4f2
Merge pull request #5637 from dmitrylyzo/check-media-type 2021-04-04 01:25:09 +02:00
Dmitry Lyzo
36da7a06d7
Less negation
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-04-04 02:09:57 +03:00
Bond-009
ea2bd3398b
Merge pull request #5685 from Bond-009/uselessnullcheck
Remove useless null check
2021-04-03 23:50:00 +02:00
Bond-009
cb111eb767
Merge pull request #5661 from ferferga/openapi-product-version
Return Major.Minor.Build instead of Major.Minor.Build.Revision for OpenAPI
2021-04-03 22:07:47 +02:00
Bond-009
4f387dca6e
Merge pull request #5598 from cvium/fix_hls_default_values 2021-04-03 19:36:41 +02:00
Bond-009
9f21dd63ae
Merge pull request #5684 from jellyfin/dependabot/nuget/Microsoft.NET.Test.Sdk-16.9.4
Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4
2021-04-03 19:25:25 +02:00
crobibero
31d1dbfda6 Add SessionDiscoveryInfo to generated api-docs 2021-04-03 06:54:09 -06:00
Bond-009
959a09bdb0
Merge pull request #5676 from Bond-009/useless 2021-04-03 02:00:03 +02:00
Bond_009
0a00a73fec Remove useless null check 2021-04-03 01:46:31 +02:00
dependabot[bot]
7c70205326
Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.9.1 to 16.9.4.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.9.1...v16.9.4)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-02 22:42:12 +00:00
Bond-009
8cb3dc8469
Merge pull request #5590 from jellyfin/dependabot/nuget/Microsoft.Extensions.Diagnostics.HealthChecks-5.0.4
Bump Microsoft.Extensions.Diagnostics.HealthChecks from 5.0.3 to 5.0.4
2021-04-03 00:41:40 +02:00
Bond-009
ec0ef1530c
Merge pull request #5602 from Ullmie02/IP-string-IP 2021-04-03 00:32:43 +02:00
dependabot[bot]
820a373016
Bump Microsoft.Extensions.Diagnostics.HealthChecks from 5.0.3 to 5.0.4
Bumps [Microsoft.Extensions.Diagnostics.HealthChecks](https://github.com/dotnet/aspnetcore) from 5.0.3 to 5.0.4.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.3...v5.0.4)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-02 22:27:11 +00:00
Bond-009
a92736baad
Merge pull request #5174 from barronpm/authenticateuser-cleanup 2021-04-03 00:26:56 +02:00
Bond-009
fd66ca25cd
Merge pull request #5652 from jellyfin/dependabot/nuget/Serilog.AspNetCore-4.1.0
Bump Serilog.AspNetCore from 3.4.0 to 4.1.0
2021-04-03 00:26:00 +02:00
BaronGreenback
d9a50cb510 Various DLNA Optimizations 2021-04-02 19:06:38 +01:00
Bond-009
6f373f615b
Merge pull request #5675 from Bond-009/copytotests
Add tests for CopyToExtensions
2021-04-02 16:38:30 +02:00
Bond-009
a0258618ac
Update Emby.Server.Implementations/Library/Resolvers/TV/SeriesResolver.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-04-01 21:24:34 +02:00
Bond_009
c533b20496 Remove ManagedFileSystem.IsRootPath
`Path.IsPathRooted` should be used instead
2021-04-01 19:39:00 +02:00
Max Rumpf
21e7ceae8e
StreamBuilder tweaks (#5668)
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-04-01 19:18:14 +02:00
Bond_009
aa76957338 Remove useless code 2021-04-01 19:16:00 +02:00
Bond_009
11f7ab4dd4 Add tests for CopyToExtensions 2021-04-01 19:13:03 +02:00
Bond-009
7c51d0a50e
Merge pull request #5671 from jellyfin/tmdbmovieprovider-originaltitle
set original title in tmdbmovieprovider
2021-04-01 17:39:22 +02:00
Bond-009
38913a42b4
Merge pull request #5672 from jellyfin/skip-bad-images
ensure only valid images are saved in ItemImageProvider
2021-04-01 17:38:05 +02:00
Claus Vium
df60d176b8
ensure only valid images are saved in ItemImageProvider 2021-04-01 15:27:28 +02:00
Claus Vium
28a0eb6d53
set original title in tmdbmovieprovider 2021-04-01 14:28:03 +02:00
Brian C. Arnold
3820671724 Merge remote-tracking branch 'main/master' into FixMessageCommand 2021-03-31 08:08:27 -04:00
BrianCArnold
4fa2a32d81
Apply suggestions from code review
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-31 01:24:38 -04:00
BrianCArnold
af03b280bc
Update SessionController.cs 2021-03-31 01:23:51 -04:00
Bond-009
b49d50e634
Merge pull request #5467 from Ullmie02/nfo-fixes 2021-03-30 15:35:56 +02:00
Fernando Fernández
8c6bd2537c Return Major.Minor.Build instead of Major.Minor.Build.Revision for OpenAPI version 2021-03-30 15:15:16 +02:00
BrianCArnold
80fe48fda9
Update SessionController.cs
Removed unnecessary construction of POCO to represent data from POST body
2021-03-30 07:29:40 -04:00
Brian Arnold
54107ae882 Fix spacing requirement for MessageCommand. 2021-03-29 11:40:07 -04:00
Brian Arnold
ca25301e64 Added Required attribute to Text property of MessageCommand. 2021-03-29 10:10:44 -04:00
dependabot[bot]
949ef2ed10
Bump BlurHashSharp from 1.1.1 to 1.2.0
Bumps [BlurHashSharp](https://github.com/Bond-009/BlurHashSharp) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/Bond-009/BlurHashSharp/releases)
- [Commits](https://github.com/Bond-009/BlurHashSharp/commits/v1.2.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-29 12:00:57 +00:00
dependabot[bot]
023467ebce
Bump Serilog.AspNetCore from 3.4.0 to 4.1.0
Bumps [Serilog.AspNetCore](https://github.com/serilog/serilog-aspnetcore) from 3.4.0 to 4.1.0.
- [Release notes](https://github.com/serilog/serilog-aspnetcore/releases)
- [Commits](https://github.com/serilog/serilog-aspnetcore/compare/v3.4.0...v4.1.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-29 12:00:44 +00:00
David
1669cb6618 Split valid and invalid tests 2021-03-29 10:35:29 +02:00
Brian C. Arnold
998833ea6e Removed null check for body object and user [Required] attribute in replacement. 2021-03-27 23:29:24 -04:00
Brian Arnold
f114ba57dd Fixed comment and code block runes to match coding
standards required by Jellyfin team.
2021-03-27 23:29:24 -04:00
Brian Arnold
81e3e5ca48 Changed SessionController.SendMessageCommand
implementation receive data in the POST body, as that is how the
jellyfin-web client currently posts the data to the server.

Resolves: #5628
2021-03-27 23:29:24 -04:00
Bond-009
a890a85092
Merge pull request #5495 from BaronGreenback/RemoteAccessFix 2021-03-27 17:24:47 +01:00
Dmitry Lyzo
364e8931af Check appropriate profile type 2021-03-27 11:53:57 +03:00
Claus Vium
9144d11a9d
Merge pull request #5624 from crobibero/subtitle-format 2021-03-27 09:25:34 +01:00
BaronGreenback
aae2aad0f2 changed split to single quotes 2021-03-27 08:16:48 +00:00
Bond-009
1de031a7c3
Merge pull request #5634 from cvium/directoryservice-case-sensitive
make directoryservice cache case sensitive
2021-03-27 00:51:52 +01:00
crobibero
afe3b5999e Fix route naming 2021-03-26 17:40:55 -06:00
Claus Vium
90d9530aed
Merge pull request #5629 from lmaonator/fix-cast-stream-selection 2021-03-27 00:34:57 +01:00
cvium
7670189561 make directoryservice cache case sensitive 2021-03-27 00:26:56 +01:00