photonconvergence
09e8a7e62c
Fix extra type differentiation
...
Change rules for Featurettes and Shorts so they don't both get classed as ExtraType.Clip.
Fix test that these changes break
2022-10-27 18:01:04 -07:00
Bond_009
224bb355dd
Rewrite BaseItem.ModifySortChunks
2022-10-12 17:43:01 +02:00
Claus Vium
b137d0cc2b
Merge pull request #7514 from Shadowghost/music-extend
2022-10-07 15:21:00 +02:00
Bond_009
f5613add1a
Remove extra argument
2022-10-06 20:39:22 +02:00
Bond_009
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Luke F
e579b4d42d
Backport pull request #8189 from jellyfin/release-10.8.z
...
Fix GetItems IndexOutOfRangeException when IDs do not exist
Original-merge: 527ed0607d5f31a232293b39daac19018518b1a0
Merged-by: Claus Vium <cvium@users.noreply.github.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-09-23 23:09:34 -04:00
Zach Phelan
8857edb66c
Add function back for compatibility, add sorting
2022-09-13 17:13:02 -06:00
Zach Phelan
c71d6f2358
Sort special features same as other spots, removing unnecssary function
...
Added to contributors
2022-09-13 16:56:23 -06:00
Shadowghost
61fa325ef0
Extend music parsing
2022-09-13 17:20:22 +02:00
Claus Vium
1cbf5431aa
Merge pull request #8250 from Bond-009/minor18
...
Minor cleanup
2022-09-09 13:27:52 +02:00
Bond_009
5036afd691
Minor cleanup
2022-08-18 13:56:23 +02:00
luz paz
9ec2870b10
Fix various typos
...
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Niels van Velzen
61afd029df
Check for empty guid
2022-08-14 12:58:38 +02:00
Niels van Velzen
0f91244239
Use Guid for adjacentTo API parameter
2022-08-14 12:47:25 +02:00
Shadowghost
7b05e0a413
Backport pull request #8209 from jellyfin/release-10.8.z
...
Fix series query including missing episodes when it should not
Original-merge: 9357d610b13e2d9a759d69ed80dd71108af1e602
Merged-by: Claus Vium <cvium@users.noreply.github.com>
Backported-by: Joshua Boniface <joshua@boniface.me>
2022-08-13 21:46:34 -04:00
Joshua Boniface
b3675ebce0
Backport pull request #8191 from jellyfin/release-10.8.z
...
fix: remove Virtual episodes when their physical counterpart exists
Authored-by: cvium <clausvium@gmail.com>
Merged-by: Bond-009 <bond.009@outlook.com>
Original-merge: 77a007a24d5eef1209766d31e2f5038b11d1a8d4
2022-08-01 14:25:46 -04:00
Joshua Boniface
0356a15056
Backport pull request #8163 from jellyfin/release-10.8.z
...
Don't refresh playlists on album refresh
Authored-by: David Ullmer <davidullmer@outlook.de>
Merged-by: Claus Vium <cvium@users.noreply.github.com>
Original-merge: 444b0ea3105517900e869d73223b8bf984f28aa4
2022-08-01 14:25:44 -04:00
Mikal Stordal
8e1796f08a
Add escape hatch for Series merging
...
This is an universal solution for plugins to override how series are merged.
The reason to override is so we can set the same provider id on multiple items without merging them, while using another id for merging them. Having an (optional) provider id not tied to any online database allows plugins to use their own rules for merging series.
2022-07-03 00:32:09 +02:00
Bond-009
2b1a915ead
Merge pull request #7604 from Jellifi007/fixes-diactritics
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d9734381472b301deb0118bbb8da2a769a65e)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Bond_009
7fdc0e3c3d
BaseItem: remove unused function
2022-03-11 16:21:32 +01:00
Claus Vium
53209830e7
Merge pull request #7346 from Bond-009/guid
...
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Claus Vium
136eab9b1e
Merge pull request #7370 from crobibero/internal-metadata-path
...
Only add internal files if the internal metadata path exists
2022-03-04 08:13:58 +01:00
Cody Robibero
fc5c6c0404
Use IFileSystem
2022-02-28 17:14:33 -07:00
Joe Rogers
354f22d065
Add post filtering for theme song and video
2022-02-27 23:38:00 +01:00
Joe Rogers
15053516f8
Rewrite tests for coverage and less duplication
...
Address minor warnings
Revert making GetInternalMetadataPath mockable
2022-02-21 22:25:58 +01:00
Bond_009
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Shadowghost
719b707281
feat(external-media): refactor to generic provider, extend tests and file recognition, consolidate and extend NamingOptions
2022-02-18 22:19:33 +01:00
Claus Vium
488ce51032
Remove some allocations ( #7246 )
2022-01-28 12:21:40 +01:00
Bond_009
2dcb2f8a9f
Ban the usage of Task.Result
...
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
2022-01-22 16:48:31 +01:00
Cody Robibero
a60cb280a3
Properly populate QueryResult
2022-01-20 08:53:06 -07:00
Dmitry Lyzo
f28384ba30
Ignore JSON serialization for special features of movie.
...
When refreshing the metadata of the video with a local trailer, the server gets
stuck trying to read the database and save the item at the same time.
2022-01-14 22:15:14 +03:00
Cody Robibero
a0f248e200
Merge pull request #7134 from adavier/trakt-episode-links
2022-01-11 16:11:25 -07:00
Joe Rogers
a26509a98a
Keep from serializing trailers into database
2022-01-07 22:33:31 +01:00
adavier
9574d13059
Implement trakt episode links using the implementation from Series.cs
...
The code is the same as `MediaBrowser.Controller/Entities/TV/Series.cs`, using the imdbID to generate Trakt links.
The trakt url for episodes is `https://trakt.tv/episodes/{0} `.
2022-01-07 19:47:36 +00:00
Cody Robibero
7bfc6b5679
Remove more warnings
2021-12-27 07:38:06 -07:00
Bond_009
cbfa355e31
Update StyleCop
2021-12-24 18:28:27 +01:00
Cody Robibero
a8a8ce4e7b
Fix build from PR merging
2021-12-23 19:27:51 -07:00
Cody Robibero
076a13abeb
Merge pull request #7029 from cvium/allocations_maybe
2021-12-24 01:59:25 +00:00
Cody Robibero
00211ca056
Merge pull request #7028 from cvium/everything_went_wrong
2021-12-22 17:57:00 +00:00
cvium
05c8834a3a
Don't cache special feature ids
2021-12-21 00:10:58 +01:00
cvium
9158511017
Don't skip extras refresh when replacing metadata or doing a full refresh
2021-12-20 23:58:09 +01:00
cvium
b880dc8a4a
Use our own Contains extension
2021-12-20 13:31:07 +01:00
cvium
83a94aa612
Fix extras folders
2021-12-20 12:15:20 +01:00
cvium
91f3ce3109
Use == instead of Object.Equals to avoid closure allocation
2021-12-19 18:24:05 +01:00
Claus Vium
9a0618552b
Merge branch 'master' into what_could_go_wrong
2021-12-15 08:38:39 +01:00
Cody Robibero
0edf77994a
Cache BaseItemKind
2021-12-14 07:41:29 -07:00
cvium
c5569c701c
Folder can't have extras
2021-12-12 19:04:22 +01:00
Cody Robibero
32629cd7da
Use BaseItemKind where possible
2021-12-12 06:11:27 -07:00
cvium
fde84a1e00
Refactor extras parsing
2021-12-07 15:24:57 +01:00
Jonas Resch
180e2dc329
Prevent crashes in specific scenarios
2021-12-01 21:05:43 +01:00