Bond-009
3ff110984a
Merge branch 'master' into readonlyspan
2020-07-24 09:40:44 +02:00
Joshua M. Boniface
8960d6256f
Merge pull request #3659 from Bond-009/stringbuilder
...
Optimize StringBuilder.Append calls
2020-07-23 18:08:09 -04:00
Joshua M. Boniface
fd82ecd18e
Merge pull request #3595 from Bond-009/xml
...
Improve DescriptionXmlBuilder
2020-07-23 18:06:15 -04:00
Bond-009
89ff865d40
Merge pull request #3508 from BaronGreenback/nullable
...
Part 1: nullable Emby.DLNA
2020-07-22 18:41:58 +02:00
Bond_009
4d681e3cad
Optimize StringBuilder.Append calls
2020-07-22 14:34:51 +02:00
Bond_009
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
2020-07-22 13:39:24 +02:00
Bond_009
65453c0a84
Fix build and more Append calls
2020-07-19 21:32:54 +02:00
Bond_009
39be99504f
Improve DescriptionXmlBuilder
...
* Replace XML escape code with SecurityElement.Escape
* Optimize StringBuilder.Append calls
2020-07-19 21:20:18 +02:00
BaronGreenback
672a35db94
Update DlnaServerService.cs
2020-07-19 17:54:09 +01:00
BaronGreenback
f9b0816b80
Changes a suggested.
2020-07-18 16:54:23 +01:00
BaronGreenback
0f696104ac
using missing.
2020-07-17 16:23:47 +01:00
BaronGreenback
c7c28db17b
Update DlnaServerService.cs
2020-07-17 16:08:26 +01:00
BaronGreenback
d9f9412955
Update DlnaServerService.cs
2020-07-17 12:58:23 +01:00
Patrick Barron
6d1b00da64
Use Array.Empty
2020-07-04 11:54:25 -04:00
Cody Robibero
43221fc26b
Merge branch 'master' into SSDP
2020-06-20 15:33:13 -06:00
telans
7f307f9082
brace multiline if statements
2020-06-20 21:12:36 +12:00
telans
98db8f72e0
fix SA1503 for one line if statements
2020-06-20 20:35:29 +12:00
telans
8e3d874802
remove regions
2020-06-20 18:20:33 +12:00
dkanada
215ab39e00
Merge pull request #3342 from BaronGreenback/BugFix2
...
Fix for [DLNA] Many log messages from Media Renderers trying to see old events
2020-06-16 19:02:16 +09:00
Bond-009
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans
247f9c61e6
fix SA1513/SA1516
2020-06-16 16:11:30 +12:00
telans
9018f8d8be
Add full stop at end of comments (SA1629)
2020-06-16 10:37:52 +12:00
BaronGreenback
6d6793151a
Null pointer check added for subscription as 2nd param is false.
2020-06-15 10:10:52 +01:00
telans
3d9049ef08
fix SA1508
2020-06-15 10:45:55 +12:00
telans
acd4389653
fix SA1005
2020-06-15 10:41:00 +12:00
telans
726e116d5b
fix SA1510
2020-06-15 10:40:57 +12:00
Patrick Barron
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
BaronGreenback
4d9171f691
Update DlnaEntryPoint.cs
...
Left a _config behind.
2020-06-11 22:40:43 +01:00
BaronGreenback
5cf44e7736
Removed spaces
2020-06-09 22:11:23 +01:00
BaronGreenback
93568be3e7
Updates
2020-06-09 22:05:22 +01:00
crobibero
57d1dbfe7b
undo erroneous changes
2020-06-05 18:29:58 -06:00
crobibero
44957c5a9a
Use typed logger where possible
2020-06-05 18:15:56 -06:00
Patrick Barron
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00
Vasily
668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
...
Enable nullabe reference types for MediaBrowser.Model
2020-06-03 12:26:54 +03:00
Bond_009
7439e095e2
Merge branch 'master' into nullable3
2020-05-27 20:49:18 +02:00
Bond_009
10e381f66f
Fix some 'bugs' flagged by sonarcloud
2020-05-25 23:52:51 +02:00
Patrick Barron
c464f700db
Remove redundant qualifiers
2020-05-20 13:07:53 -04:00
Patrick Barron
aca7e221d8
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Activity/ActivityLogEntryPoint.cs
# Emby.Server.Implementations/ApplicationHost.cs
# Emby.Server.Implementations/Devices/DeviceManager.cs
# Jellyfin.Server/Jellyfin.Server.csproj
# Jellyfin.Server/Migrations/MigrationRunner.cs
# MediaBrowser.Controller/Devices/IDeviceManager.cs
2020-05-15 17:20:07 -04:00
Patrick Barron
9ad839c776
Initial migration code
2020-05-12 22:10:35 -04:00
Bond_009
15634a1913
Merge branch 'master' into websocket
2020-05-02 00:54:04 +02:00
BaronGreenback
8a69300bf5
Changes styles as suggested by @barronpm
...
Added addtional comments & source type as per intellisense suggestion
change code as per sonacloud
2020-04-29 12:24:01 +01:00
BaronGreenback
ebd589aa86
Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
...
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).
Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)
All these changes are related.
Changes
1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986 . Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
2020-04-28 21:57:39 +01:00
BaronGreenback
a3140f83c6
Revert "Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored."
...
This reverts commit 2aaecb8e14
.
2020-04-28 21:51:49 +01:00
BaronGreenback
2aaecb8e14
Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
...
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).
Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)
All these changes are related.
Changes
1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986 . Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
2020-04-28 21:45:46 +01:00
Joshua M. Boniface
4fa6d1ccee
Merge pull request #2940 from balu92/master
...
Fix missing colons
2020-04-26 15:22:38 -04:00
Joshua M. Boniface
ca4b6836c1
Merge pull request #2906 from randrey/dlna-nullref-fix
...
Fix InvalidOperationException while browsing via DLNA client.
2020-04-26 15:02:34 -04:00
Bond_009
118f30059c
Merge branch 'master' into nullable4
2020-04-23 11:29:19 +02:00
Bond-009
c0b3c11b2e
Merge pull request #2846 from jellyfin/azure
...
Remove requirement to build web during server builds
2020-04-22 00:17:44 +02:00
Mark Monteiro
c5f163293f
Add <ProjectGuid> properties to all project files
...
This is required for SonarCloud analysis to run
2020-04-21 16:21:09 -04:00
Unknown
80f5dd1e59
Fixed missing colons
...
some colons were missing from the default ProtocolInfo string
2020-04-20 13:52:50 +01:00