From 2e39a80c634b53a46edff784bdbb9d8306f81e41 Mon Sep 17 00:00:00 2001 From: Joshua Boniface Date: Thu, 10 Jan 2019 23:25:58 -0500 Subject: [PATCH 1/4] Update pull request template --- .github/pull_request_template.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..0edc49218 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,6 @@ +**Changes** +Describe your changes here in 1-5 sentences. + +**Issues** +Tag any issues that this PR solves here. +Fixes # From fa4c6ee8b24bfd1e150083229f9d8d4b9c1a283c Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Fri, 11 Jan 2019 10:40:14 -0500 Subject: [PATCH 2/4] Add blurb about title --- .github/pull_request_template.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0edc49218..9a0cde9be 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,3 +1,5 @@ +Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). + **Changes** Describe your changes here in 1-5 sentences. From 7a3b01da1baa0ee0f503353f21f36c4904c981a3 Mon Sep 17 00:00:00 2001 From: Vasily Date: Fri, 11 Jan 2019 23:02:51 -0500 Subject: [PATCH 3/4] Add link to writing good messages article Co-Authored-By: joshuaboniface --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9a0cde9be..ac1ddcb3e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,5 @@ Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). +For a good inspiration of what to write in commit messages and PR have a look at https://chris.beams.io/posts/git-commit/ **Changes** Describe your changes here in 1-5 sentences. From 53b8aa52e11c5d993aa57a9eb9f00838d7fdd1c8 Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Fri, 11 Jan 2019 23:05:38 -0500 Subject: [PATCH 4/4] Add link to our contributing docs as well --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ac1ddcb3e..b2b3cf241 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,5 +1,5 @@ Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). -For a good inspiration of what to write in commit messages and PR have a look at https://chris.beams.io/posts/git-commit/ +For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our https://jellyfin.readthedocs.io/en/latest/developer-docs/contributing/ page. **Changes** Describe your changes here in 1-5 sentences.