diff --git a/MediaBrowser.Api/ScheduledTasks/ScheduledTasksWebSocketListener.cs b/MediaBrowser.Api/ScheduledTasks/ScheduledTasksWebSocketListener.cs
index b0c4b29c1..d24a18743 100644
--- a/MediaBrowser.Api/ScheduledTasks/ScheduledTasksWebSocketListener.cs
+++ b/MediaBrowser.Api/ScheduledTasks/ScheduledTasksWebSocketListener.cs
@@ -58,9 +58,8 @@ namespace MediaBrowser.Api.ScheduledTasks
///
/// Gets the data to send.
///
- /// The state.
/// Task{IEnumerable{TaskInfo}}.
- protected override Task> GetDataToSend(WebSocketListenerState state, CancellationToken cancellationToken)
+ protected override Task> GetDataToSend()
{
return Task.FromResult(TaskManager.ScheduledTasks
.OrderBy(i => i.Name)
diff --git a/MediaBrowser.Api/Session/SessionInfoWebSocketListener.cs b/MediaBrowser.Api/Session/SessionInfoWebSocketListener.cs
index beb2fb11d..b79e9f84b 100644
--- a/MediaBrowser.Api/Session/SessionInfoWebSocketListener.cs
+++ b/MediaBrowser.Api/Session/SessionInfoWebSocketListener.cs
@@ -79,9 +79,8 @@ namespace MediaBrowser.Api.Session
///
/// Gets the data to send.
///
- /// The state.
/// Task{SystemInfo}.
- protected override Task> GetDataToSend(WebSocketListenerState state, CancellationToken cancellationToken)
+ protected override Task> GetDataToSend()
{
return Task.FromResult(_sessionManager.Sessions);
}
diff --git a/MediaBrowser.Api/System/ActivityLogWebSocketListener.cs b/MediaBrowser.Api/System/ActivityLogWebSocketListener.cs
index 43f3c5a22..a036619b8 100644
--- a/MediaBrowser.Api/System/ActivityLogWebSocketListener.cs
+++ b/MediaBrowser.Api/System/ActivityLogWebSocketListener.cs
@@ -38,9 +38,8 @@ namespace MediaBrowser.Api.System
///
/// Gets the data to send.
///
- /// The state.
/// Task{SystemInfo}.
- protected override Task> GetDataToSend(WebSocketListenerState state, CancellationToken CancellationToken)
+ protected override Task> GetDataToSend()
{
return Task.FromResult(new List());
}
diff --git a/MediaBrowser.Controller/Net/BasePeriodicWebSocketListener.cs b/MediaBrowser.Controller/Net/BasePeriodicWebSocketListener.cs
index d2d0fbbc6..5a6a0ea31 100644
--- a/MediaBrowser.Controller/Net/BasePeriodicWebSocketListener.cs
+++ b/MediaBrowser.Controller/Net/BasePeriodicWebSocketListener.cs
@@ -22,8 +22,8 @@ namespace MediaBrowser.Controller.Net
///
/// The _active connections
///
- protected readonly List> ActiveConnections =
- new List>();
+ protected readonly List> ActiveConnections =
+ new List>();
///
/// Gets the name.
@@ -34,9 +34,8 @@ namespace MediaBrowser.Controller.Net
///
/// Gets the data to send.
///
- /// The state.
/// Task{`1}.
- protected abstract Task GetDataToSend(TStateType state, CancellationToken cancellationToken);
+ protected abstract Task GetDataToSend();
///
/// The logger
@@ -80,8 +79,6 @@ namespace MediaBrowser.Controller.Net
protected readonly CultureInfo UsCulture = new CultureInfo("en-US");
- protected bool SendOnTimer => false;
-
///
/// Starts sending messages over a web socket
///
@@ -97,10 +94,6 @@ namespace MediaBrowser.Controller.Net
Logger.LogDebug("{1} Begin transmitting over websocket to {0}", message.Connection.RemoteEndPoint, GetType().Name);
- var timer = SendOnTimer ?
- new Timer(TimerCallback, message.Connection, Timeout.Infinite, Timeout.Infinite) :
- null;
-
var state = new TStateType
{
IntervalMs = periodMs,
@@ -109,47 +102,13 @@ namespace MediaBrowser.Controller.Net
lock (ActiveConnections)
{
- ActiveConnections.Add(new Tuple(message.Connection, cancellationTokenSource, timer, state));
+ ActiveConnections.Add(new Tuple(message.Connection, cancellationTokenSource, state));
}
-
- if (timer != null)
- {
- timer.Change(TimeSpan.FromMilliseconds(dueTimeMs), TimeSpan.FromMilliseconds(periodMs));
- }
- }
-
- ///
- /// Timers the callback.
- ///
- /// The state.
- private void TimerCallback(object state)
- {
- var connection = (IWebSocketConnection)state;
-
- Tuple tuple;
-
- lock (ActiveConnections)
- {
- tuple = ActiveConnections.FirstOrDefault(c => c.Item1 == connection);
- }
-
- if (tuple == null)
- {
- return;
- }
-
- if (connection.State != WebSocketState.Open || tuple.Item2.IsCancellationRequested)
- {
- DisposeConnection(tuple);
- return;
- }
-
- SendData(tuple);
}
protected void SendData(bool force)
{
- Tuple[] tuples;
+ Tuple[] tuples;
lock (ActiveConnections)
{
@@ -158,7 +117,7 @@ namespace MediaBrowser.Controller.Net
{
if (c.Item1.State == WebSocketState.Open && !c.Item2.IsCancellationRequested)
{
- var state = c.Item4;
+ var state = c.Item3;
if (force || (DateTime.UtcNow - state.DateLastSendUtc).TotalMilliseconds >= state.IntervalMs)
{
@@ -177,17 +136,17 @@ namespace MediaBrowser.Controller.Net
}
}
- private async void SendData(Tuple tuple)
+ private async void SendData(Tuple tuple)
{
var connection = tuple.Item1;
try
{
- var state = tuple.Item4;
+ var state = tuple.Item3;
var cancellationToken = tuple.Item2.Token;
- var data = await GetDataToSend(state, cancellationToken).ConfigureAwait(false);
+ var data = await GetDataToSend().ConfigureAwait(false);
if (data != null)
{
@@ -236,24 +195,11 @@ namespace MediaBrowser.Controller.Net
/// Disposes the connection.
///
/// The connection.
- private void DisposeConnection(Tuple connection)
+ private void DisposeConnection(Tuple connection)
{
Logger.LogDebug("{1} stop transmitting over websocket to {0}", connection.Item1.RemoteEndPoint, GetType().Name);
connection.Item1.Dispose();
- var timer = connection.Item3;
-
- if (timer != null)
- {
- try
- {
- timer.Dispose();
- }
- catch (ObjectDisposedException)
- {
- //TODO Investigate and properly fix.
- }
- }
try
{