From 4c2b543b307b55b2220472c59396b9b4a604cfb7 Mon Sep 17 00:00:00 2001
From: Mark Monteiro <marknr.monteiro@protonmail.com>
Date: Fri, 6 Mar 2020 21:51:50 +0100
Subject: [PATCH] Rename IUpdater to IMigrationRoutine

---
 .../{IUpdater.cs => IMigrationRoutine.cs}      |  8 ++++----
 Jellyfin.Server/Migrations/MigrationRunner.cs  | 18 +++++++++---------
 .../Routines/CreateUserLoggingConfigFile.cs    |  2 +-
 .../Routines/DisableTranscodingThrottling.cs   |  2 +-
 4 files changed, 15 insertions(+), 15 deletions(-)
 rename Jellyfin.Server/Migrations/{IUpdater.cs => IMigrationRoutine.cs} (69%)

diff --git a/Jellyfin.Server/Migrations/IUpdater.cs b/Jellyfin.Server/Migrations/IMigrationRoutine.cs
similarity index 69%
rename from Jellyfin.Server/Migrations/IUpdater.cs
rename to Jellyfin.Server/Migrations/IMigrationRoutine.cs
index 9b749841c..20a3aa3d6 100644
--- a/Jellyfin.Server/Migrations/IUpdater.cs
+++ b/Jellyfin.Server/Migrations/IMigrationRoutine.cs
@@ -4,20 +4,20 @@ using Microsoft.Extensions.Logging;
 namespace Jellyfin.Server.Migrations
 {
     /// <summary>
-    /// Interface that descibes a migration routine.
+    /// Interface that describes a migration routine.
     /// </summary>
-    internal interface IUpdater
+    internal interface IMigrationRoutine
     {
         /// <summary>
         /// Gets the name of the migration, must be unique.
         /// </summary>
-        public abstract string Name { get; }
+        public string Name { get; }
 
         /// <summary>
         /// Execute the migration routine.
         /// </summary>
         /// <param name="host">Host that hosts current version.</param>
         /// <param name="logger">Host logger.</param>
-        public abstract void Perform(CoreAppHost host, ILogger logger);
+        public void Perform(CoreAppHost host, ILogger logger);
     }
 }
diff --git a/Jellyfin.Server/Migrations/MigrationRunner.cs b/Jellyfin.Server/Migrations/MigrationRunner.cs
index ac7f3d77a..8e786f34e 100644
--- a/Jellyfin.Server/Migrations/MigrationRunner.cs
+++ b/Jellyfin.Server/Migrations/MigrationRunner.cs
@@ -13,7 +13,7 @@ namespace Jellyfin.Server.Migrations
         /// <summary>
         /// The list of known migrations, in order of applicability.
         /// </summary>
-        internal static readonly IUpdater[] Migrations =
+        internal static readonly IMigrationRoutine[] Migrations =
         {
             new Routines.DisableTranscodingThrottling(),
             new Routines.CreateUserLoggingConfigFile()
@@ -43,26 +43,26 @@ namespace Jellyfin.Server.Migrations
 
             for (var i = 0; i < Migrations.Length; i++)
             {
-                var updater = Migrations[i];
-                if (applied.Contains(updater.Name))
+                var migrationRoutine = Migrations[i];
+                if (applied.Contains(migrationRoutine.Name))
                 {
-                    logger.LogDebug("Skipping migration {Name} as it is already applied", updater.Name);
+                    logger.LogDebug("Skipping migration {Name} as it is already applied", migrationRoutine.Name);
                     continue;
                 }
 
-                logger.LogInformation("Applying migration {Name}", updater.Name);
+                logger.LogInformation("Applying migration {Name}", migrationRoutine.Name);
                 try
                 {
-                    updater.Perform(host, logger);
+                    migrationRoutine.Perform(host, logger);
                 }
                 catch (Exception ex)
                 {
-                    logger.LogError(ex, "Cannot apply migration {Name}", updater.Name);
+                    logger.LogError(ex, "Cannot apply migration {Name}", migrationRoutine.Name);
                     continue;
                 }
 
-                logger.LogInformation("Migration {Name} applied successfully", updater.Name);
-                applied.Add(updater.Name);
+                logger.LogInformation("Migration {Name} applied successfully", migrationRoutine.Name);
+                applied.Add(migrationRoutine.Name);
             }
 
             if (applied.Count > migrationOptions.Applied.Length)
diff --git a/Jellyfin.Server/Migrations/Routines/CreateUserLoggingConfigFile.cs b/Jellyfin.Server/Migrations/Routines/CreateUserLoggingConfigFile.cs
index 7a089680e..6dbeb2776 100644
--- a/Jellyfin.Server/Migrations/Routines/CreateUserLoggingConfigFile.cs
+++ b/Jellyfin.Server/Migrations/Routines/CreateUserLoggingConfigFile.cs
@@ -13,7 +13,7 @@ namespace Jellyfin.Server.Migrations.Routines
     /// If the deprecated logging.json file exists and has a custom config, it will be used as logging.user.json,
     /// otherwise a blank file will be created.
     /// </summary>
-    internal class CreateUserLoggingConfigFile : IUpdater
+    internal class CreateUserLoggingConfigFile : IMigrationRoutine
     {
         /// <summary>
         /// An empty logging JSON configuration, which will be used as the default contents for the user settings config file.
diff --git a/Jellyfin.Server/Migrations/Routines/DisableTranscodingThrottling.cs b/Jellyfin.Server/Migrations/Routines/DisableTranscodingThrottling.cs
index eff6469e2..db0bef885 100644
--- a/Jellyfin.Server/Migrations/Routines/DisableTranscodingThrottling.cs
+++ b/Jellyfin.Server/Migrations/Routines/DisableTranscodingThrottling.cs
@@ -10,7 +10,7 @@ namespace Jellyfin.Server.Migrations.Routines
     /// <summary>
     /// Updater that takes care of bringing configuration up to 10.5.0 standards.
     /// </summary>
-    internal class DisableTranscodingThrottling : IUpdater
+    internal class DisableTranscodingThrottling : IMigrationRoutine
     {
         /// <inheritdoc/>
         public string Name => "DisableTranscodingThrottling";