lgladsden/jellyfin-server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use PostAsJsonAsync where possible

Browse Source
This commit is contained in:
Bond_009 2021-12-01 15:58:23 +01:00
parent beafd6eaab
commit 40be86eec0
4 changed files with 9 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/Jellyfin.Server.Integration.Tests/Controllers/DlnaControllerTests.cs
View File

@ -63,8 +63,7 @@ namespace Jellyfin.Server.Integration.Tests.Controllers
Name = "ThisProfileDoesNotExist" Name = "ThisProfileDoesNotExist"
}; };
using var content = JsonContent.Create(deviceProfile, options: _jsonOptions); using var getResponse = await client.PostAsJsonAsync("/Dlna/Profiles/" + NonExistentProfile, deviceProfile, _jsonOptions).ConfigureAwait(false);
using var getResponse = await client.PostAsync("/Dlna/Profiles/" + NonExistentProfile, content).ConfigureAwait(false);
Assert.Equal(HttpStatusCode.NotFound, getResponse.StatusCode); Assert.Equal(HttpStatusCode.NotFound, getResponse.StatusCode);
} }
@ -80,8 +79,7 @@ namespace Jellyfin.Server.Integration.Tests.Controllers
Name = "ThisProfileIsNew" Name = "ThisProfileIsNew"
}; };
using var content = JsonContent.Create(deviceProfile, options: _jsonOptions); using var getResponse = await client.PostAsJsonAsync("/Dlna/Profiles", deviceProfile, _jsonOptions).ConfigureAwait(false);
using var getResponse = await client.PostAsync("/Dlna/Profiles", content).ConfigureAwait(false);
Assert.Equal(HttpStatusCode.NoContent, getResponse.StatusCode); Assert.Equal(HttpStatusCode.NoContent, getResponse.StatusCode);
} }
@ -119,8 +117,7 @@ namespace Jellyfin.Server.Integration.Tests.Controllers
Id = _newDeviceProfileId Id = _newDeviceProfileId
}; };
using var content = JsonContent.Create(updatedProfile, options: _jsonOptions); using var getResponse = await client.PostAsJsonAsync("/Dlna/Profiles", updatedProfile, _jsonOptions).ConfigureAwait(false);
using var getResponse = await client.PostAsync("/Dlna/Profiles", content).ConfigureAwait(false);
Assert.Equal(HttpStatusCode.NoContent, getResponse.StatusCode); Assert.Equal(HttpStatusCode.NoContent, getResponse.StatusCode);
} }

6
tests/Jellyfin.Server.Integration.Tests/Controllers/MediaStructureControllerTests.cs
View File

@ -72,8 +72,7 @@ namespace Jellyfin.Server.Integration.Tests.Controllers
Path = "/this/path/doesnt/exist" Path = "/this/path/doesnt/exist"
}; };
using var postContent = JsonContent.Create(data, options: _jsonOptions); var response = await client.PostAsJsonAsync("Library/VirtualFolders/Paths", data, _jsonOptions).ConfigureAwait(false);
var response = await client.PostAsync("Library/VirtualFolders/Paths", postContent).ConfigureAwait(false);
Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);
} }
@ -90,8 +89,7 @@ namespace Jellyfin.Server.Integration.Tests.Controllers
PathInfo = new MediaPathInfo("test") PathInfo = new MediaPathInfo("test")
}; };
using var postContent = JsonContent.Create(data, options: _jsonOptions); var response = await client.PostAsJsonAsync("Library/VirtualFolders/Paths/Update", data, _jsonOptions).ConfigureAwait(false);
var response = await client.PostAsync("Library/VirtualFolders/Paths/Update", postContent).ConfigureAwait(false);
Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode); Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
} }

6
tests/Jellyfin.Server.Integration.Tests/Controllers/StartupControllerTests.cs
View File

@ -37,8 +37,7 @@ namespace Jellyfin.Server.Integration.Tests.Controllers
PreferredMetadataLanguage = "nl" PreferredMetadataLanguage = "nl"
}; };
using var postContent = JsonContent.Create(config, options: _jsonOptions); using var postResponse = await client.PostAsJsonAsync("/Startup/Configuration", config, _jsonOptions).ConfigureAwait(false);
using var postResponse = await client.PostAsync("/Startup/Configuration", postContent).ConfigureAwait(false);
Assert.Equal(HttpStatusCode.NoContent, postResponse.StatusCode); Assert.Equal(HttpStatusCode.NoContent, postResponse.StatusCode);
using var getResponse = await client.GetAsync("/Startup/Configuration").ConfigureAwait(false); using var getResponse = await client.GetAsync("/Startup/Configuration").ConfigureAwait(false);
@ -80,8 +79,7 @@ namespace Jellyfin.Server.Integration.Tests.Controllers
Password = "NewPassword" Password = "NewPassword"
}; };
using var postContent = JsonContent.Create(user, options: _jsonOptions); var postResponse = await client.PostAsJsonAsync("/Startup/User", user, _jsonOptions).ConfigureAwait(false);
var postResponse = await client.PostAsync("/Startup/User", postContent).ConfigureAwait(false);
Assert.Equal(HttpStatusCode.NoContent, postResponse.StatusCode); Assert.Equal(HttpStatusCode.NoContent, postResponse.StatusCode);
var getResponse = await client.GetAsync("/Startup/User").ConfigureAwait(false); var getResponse = await client.GetAsync("/Startup/User").ConfigureAwait(false);

10
tests/Jellyfin.Server.Integration.Tests/Controllers/UserControllerTests.cs
View File

@ -32,16 +32,10 @@ namespace Jellyfin.Server.Integration.Tests.Controllers
} }
private Task<HttpResponseMessage> CreateUserByName(HttpClient httpClient, CreateUserByName request) private Task<HttpResponseMessage> CreateUserByName(HttpClient httpClient, CreateUserByName request)
{ => httpClient.PostAsJsonAsync("Users/New", request, _jsonOpions);
using var postContent = JsonContent.Create(request, options: _jsonOpions);
return httpClient.PostAsync("Users/New", postContent);
}
private Task<HttpResponseMessage> UpdateUserPassword(HttpClient httpClient, Guid userId, UpdateUserPassword request) private Task<HttpResponseMessage> UpdateUserPassword(HttpClient httpClient, Guid userId, UpdateUserPassword request)
{ => httpClient.PostAsJsonAsync("Users/" + userId.ToString("N", CultureInfo.InvariantCulture) + "/Password", request, _jsonOpions);
using var postContent = JsonContent.Create(request, options: _jsonOpions);
return httpClient.PostAsync("Users/" + userId.ToString("N", CultureInfo.InvariantCulture) + "/Password", postContent);
}
[Fact] [Fact]
[Priority(-1)] [Priority(-1)]