Apply suggestions from code review

Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
This commit is contained in:
Nyanmisaka 2020-11-28 22:32:54 +08:00 committed by GitHub
parent d72f3498bf
commit 0c6efe6317
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -555,13 +555,16 @@ namespace MediaBrowser.MediaEncoding.Encoder
// Use ffmpeg to sample 100 (we can drop this if required using thumbnail=50 for 50 frames) frames and pick the best thumbnail. Have a fall back just in case. // Use ffmpeg to sample 100 (we can drop this if required using thumbnail=50 for 50 frames) frames and pick the best thumbnail. Have a fall back just in case.
var enableThumbnail = useIFrame && !string.Equals("wtv", container, StringComparison.OrdinalIgnoreCase); var enableThumbnail = useIFrame && !string.Equals("wtv", container, StringComparison.OrdinalIgnoreCase);
if (string.IsNullOrEmpty(vf)) if (enableThumbnail)
{ {
vf = enableThumbnail ? "-vf thumbnail=24" : string.Empty; if (string.IsNullOrEmpty(vf))
} {
else vf = "-vf thumbnail=24";
{ }
vf += enableThumbnail ? ",thumbnail=24" : string.Empty; else
{
vf += ",thumbnail=24";
}
} }
var args = string.Format(CultureInfo.InvariantCulture, "-i {0}{3} -threads {4} -v quiet -vframes 1 {2} -f image2 \"{1}\"", inputPath, tempExtractPath, vf, mapArg, threads); var args = string.Format(CultureInfo.InvariantCulture, "-i {0}{3} -threads {4} -v quiet -vframes 1 {2} -f image2 \"{1}\"", inputPath, tempExtractPath, vf, mapArg, threads);