heierbtc/nix-bitcoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove custom no-upnp bitcoind builds

Browse Source 
Disabling upnp via compilation brings no substantial security benefits.
There's no way to inadvertently enable upnp, it must be set explicitly
via bitcoind.extraConfig.

But it's a huge hassle for new users who have to recompile bitcoind
before being able to use nix-bitcoin.

Also, elementsd is currently built with upnp support by default.
This commit is contained in:
Erik Arvstedt 2020-03-26 10:14:03 +01:00
parent 2d51c722cc
commit 3a606608fb
No known key found for this signature in database
GPG Key ID: 33312B944DD97846
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkgs/pinned.nix
View File

@ -4,9 +4,9 @@ let
nixBitcoinPkgsUnstable = import ./. { pkgs = unstable; }; nixBitcoinPkgsUnstable = import ./. { pkgs = unstable; };
in in
{ {
bitcoin = unstable.bitcoin.override { miniupnpc = null; };
bitcoind = unstable.bitcoind.override { miniupnpc = null; };
inherit (unstable) inherit (unstable)
bitcoin
bitcoind
clightning clightning
lnd; lnd;
inherit (nixBitcoinPkgsUnstable) electrs; inherit (nixBitcoinPkgsUnstable) electrs;