heierbtc/lnbits
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

correct error codes in tests

Browse Source
This commit is contained in:
callebtc 2022-12-14 14:59:11 +01:00
parent b5eb8b7ee8
commit fa7bbb62e2
2 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lnbits/app.py
View File

@ -184,7 +184,7 @@ def register_exception_handlers(app: FastAPI):
) )
return JSONResponse( return JSONResponse(
status_code=HTTPStatus.NO_CONTENT, status_code=HTTPStatus.INTERNAL_SERVER_ERROR,
content={"detail": exc_str}, content={"detail": exc_str},
) )
@ -192,6 +192,7 @@ def register_exception_handlers(app: FastAPI):
async def validation_exception_handler( async def validation_exception_handler(
request: Request, exc: RequestValidationError request: Request, exc: RequestValidationError
): ):
logger.error(str(exc))
# Only the browser sends "text/html" request # Only the browser sends "text/html" request
# not fail proof, but everything else get's a JSON response # not fail proof, but everything else get's a JSON response
@ -206,7 +207,7 @@ def register_exception_handlers(app: FastAPI):
) )
return JSONResponse( return JSONResponse(
status_code=HTTPStatus.NO_CONTENT, status_code=HTTPStatus.BAD_REQUEST,
content={"detail": exc.errors()}, content={"detail": exc.errors()},
) )

16
tests/core/views/test_generic.py
View File

@ -46,11 +46,11 @@ async def test_get_wallet_no_redirect(client):
i += 1 i += 1
# check GET /wallet: wrong user, expect 204 # check GET /wallet: wrong user, expect 400
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_get_wallet_with_nonexistent_user(client): async def test_get_wallet_with_nonexistent_user(client):
response = await client.get("wallet", params={"usr": "1"}) response = await client.get("wallet", params={"usr": "1"})
assert response.status_code == 204, ( assert response.status_code == 400, (
str(response.url) + " " + str(response.status_code) str(response.url) + " " + str(response.status_code)
) )
@ -91,11 +91,11 @@ async def test_get_wallet_with_user_and_wallet(client, to_user, to_wallet):
) )
# check GET /wallet: wrong wallet and user, expect 204 # check GET /wallet: wrong wallet and user, expect 400
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_get_wallet_with_user_and_wrong_wallet(client, to_user): async def test_get_wallet_with_user_and_wrong_wallet(client, to_user):
response = await client.get("wallet", params={"usr": to_user.id, "wal": "1"}) response = await client.get("wallet", params={"usr": to_user.id, "wal": "1"})
assert response.status_code == 204, ( assert response.status_code == 400, (
str(response.url) + " " + str(response.status_code) str(response.url) + " " + str(response.status_code)
) )
@ -109,20 +109,20 @@ async def test_get_extensions(client, to_user):
) )
# check GET /extensions: extensions list wrong user, expect 204 # check GET /extensions: extensions list wrong user, expect 400
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_get_extensions_wrong_user(client, to_user): async def test_get_extensions_wrong_user(client, to_user):
response = await client.get("extensions", params={"usr": "1"}) response = await client.get("extensions", params={"usr": "1"})
assert response.status_code == 204, ( assert response.status_code == 400, (
str(response.url) + " " + str(response.status_code) str(response.url) + " " + str(response.status_code)
) )
# check GET /extensions: no user given, expect code 204 no content # check GET /extensions: no user given, expect code 400 bad request
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_get_extensions_no_user(client): async def test_get_extensions_no_user(client):
response = await client.get("extensions") response = await client.get("extensions")
assert response.status_code == 204, ( # no content assert response.status_code == 400, ( # bad request
str(response.url) + " " + str(response.status_code) str(response.url) + " " + str(response.status_code)
) )