heierbtc/lnbits
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1198 from lnbits/fix/error_handling/httpexception_no_stacktrace

Browse Source 
Fix/error_handling/httpexception_no_stacktrace
This commit is contained in:
calle 2022-12-14 19:11:06 +01:00 committed by GitHub
commit e78bf8e323
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lnbits/app.py
View File

@ -174,6 +174,8 @@ def register_exception_handlers(app: FastAPI):
etype, _, tb = sys.exc_info()
traceback.print_exception(etype, exc, tb)
logger.error(f"Exception: {str(exc)}")
# Only the browser sends "text/html" request
# not fail proof, but everything else get's a JSON response
if (
request.headers
and "accept" in request.headers
@ -192,8 +194,6 @@ def register_exception_handlers(app: FastAPI):
async def validation_exception_handler(
request: Request, exc: RequestValidationError
):
etype, _, tb = sys.exc_info()
traceback.print_exception(etype, exc, tb)
logger.error(f"RequestValidationError: {str(exc)}")
# Only the browser sends "text/html" request
# not fail proof, but everything else get's a JSON response
@ -215,8 +215,6 @@ def register_exception_handlers(app: FastAPI):
@app.exception_handler(HTTPException)
async def http_exception_handler(request: Request, exc: HTTPException):
etype, _, tb = sys.exc_info()
traceback.print_exception(etype, exc, tb)
logger.error(f"HTTPException {exc.status_code}: {exc.detail}")
# Only the browser sends "text/html" request
# not fail proof, but everything else get's a JSON response